Add ecr:BatchGetImage permission to helm-publish workflow#759
Merged
yerzhan7 merged 1 commit intoMar 25, 2026
Conversation
jet-tong
approved these changes
Mar 25, 2026
| with: | ||
| role-to-assume: ${{ vars.IAM_ROLE }} | ||
| aws-region: ${{ vars.AWS_REGION }} | ||
| # We only need valid credentials for authentication with ECR, so only ecr:GetAuthorizationToken. |
Collaborator
There was a problem hiding this comment.
np: could add comment on why we need batchgetimage here appending to old comment.
It did successfully check livenessprobe:v2.18.0-eksbuild.1 in helm publish #19, do you know why it requires this BatchGetImage now? (could it be .3 vs .1?)
Contributor
Author
There was a problem hiding this comment.
I suspect this introduced the bug? #741
Thanks for reviewing!
Collaborator
There was a problem hiding this comment.
No that was part of the bug fix that allowed helm publish 19 to succeed in v2.4.1 release (which was failing before), perhaps something else was the cause?
Contributor
Author
There was a problem hiding this comment.
Yeah, you are right because the workflow still fails after this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The
verify-helm-images.shscript usescrane digestto verify sidecarimages (livenessprobe, node-driver-registrar) in the EKS ECR repo.
crane resolves manifests via HEAD/GET requests which require
ecr:BatchGetImage, but the inline session policy only grantedecr:GetAuthorizationTokenfor docker login. Addecr:BatchGetImagescoped to the EKS ECR repository. Related to #741
Manual testing:
Previous error from local reproduction:
Helm failing workflow: https://github.com/awslabs/mountpoint-s3-csi-driver/actions/runs/23543258639/job/68572809411
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.