V1 backport#775
Conversation
Signed-off-by: Tadiwa Magwenzi <tadiwaom@amazon.com>
- Ran go fix ./... in main / tests/e2e-kubernetes - Added queue: max improvement to prevent e2e runs from cancelling each other Signed-off-by: Jensen Tong <jetong@amazon.com>
jet-tong
left a comment
jet-tong
left a comment
There was a problem hiding this comment.
Main changes I see:
- Dropped k8s 1.28/1.29, added 1.34/1.35
- Bumpbed Go from 1.24 to 1.26.2, ran go fix
- Bumped github versions, and ported helm-publish workflow over
- e2e tests:
e2evolumepackage toe2epodfor k8s 1.33+ compatibility - Migrated some cluster deletion improvements
I added another round of go fix and ported concurrency: queue: max over.
But noted helm publish dry run failure: https://github.com/awslabs/mountpoint-s3-csi-driver/actions/runs/25490148274/job/74795811811
Might need to port verify-helm-images.sh over here and not use main branch verify workflow too.
There was a problem hiding this comment.
Regarding my comment on helm publish:
But noted helm publish dry run failure: https://github.com/awslabs/mountpoint-s3-csi-driver/actions/runs/25490148274/job/74795811811 Might need to port verify-helm-images.sh over here and not use main branch verify workflow too.
Since it's now CI is working perhaps the helm publish step could be a separate PR (if so we'll need to track the task).
Since I changed something near the end, approval from another reviewer is needed.
Main branch verification script includes headroom pod image check that fails for v1 - this commit fixes that. Signed-off-by: Jensen Tong <jetong@amazon.com>
Signed-off-by: Jensen Tong <jetong@amazon.com>
|
Addressed my own comment on helm-publish - dry run now passes when ignoring headroom pod image check. Diff between main and v1-backport verify-helm-images.shdiff <(git show upstream/main:scripts/verify-helm-images.sh) scripts/verify-helm-images.sh
< # - Headroom pod image (pause container)
<
< # Verify headroom pod image (used when experimental.reserveHeadroomForMountpointPods is enabled)
< HEADROOM_IMAGE=$(yq eval '.experimental.headroomPodImage' "${VALUES_FILE}")
<
< echo "=== Headroom Pod Image (Pause Container) ==="
< verify_public_ecr_image "${HEADROOM_IMAGE}" |
4 participants
Issue #, if available:
Description of changes:
Update v1 workflow files to match v2 where appropriate.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.