Handle ErrNotExist in PodUnmounter wait loops and source removal#816
Open
guessi wants to merge 1 commit into
Open
Handle ErrNotExist in PodUnmounter wait loops and source removal#816guessi wants to merge 1 commit into
guessi wants to merge 1 commit into
Conversation
When the mount source directory is concurrently removed (e.g., by another cleanup path), waitUntilMountpointIsUnmounted, waitUntilMountpointIsUnused, and os.Remove would return errors instead of treating the absence as the desired end state. Treat fs.ErrNotExist as success in all three locations since a non-existent path satisfies the postcondition of each operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #815
Description of changes:
When the mount source directory is concurrently removed by another cleanup path,
waitUntilMountpointIsUnmounted,waitUntilMountpointIsUnused, andos.Removereturn errors instead of treating the absence as the desired end state.This patch treats
fs.ErrNotExistas success in all three locations since a non-existent path satisfies the postcondition of each operation:waitUntilMountpointIsUnmounted— path gone means it is no longer a mountpointwaitUntilMountpointIsUnused— path gone means no references remainos.RemoveinunmountAndRemoveMountpointSource— path gone means removal already happenedThis is consistent with the existing
ErrNotExistguard at the top ofunmountAndRemoveMountpointSource.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.