Acquire per-pod lock in dangling mount cleanup path#818
Open
guessi wants to merge 1 commit into
Open
Conversation
CleanupDanglingMounts calls unmountAndRemoveMountpointSource without holding lockMountpointPod, while the normal unmount path (triggered by HandleMountpointPodUpdate) holds the lock via unmountMountpointPodIfNeeded. This allows both paths to race on the same mount directory, where the dangling path can delete the directory while the normal path is still polling it. Acquire the same per-pod lock in the dangling cleanup branch to serialize concurrent operations on the same Mountpoint Pod mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #817
Description of changes:
CleanupDanglingMountscallsunmountAndRemoveMountpointSourcewithout holdinglockMountpointPod, while the normal unmount path (triggered byHandleMountpointPodUpdate) holds the lock viaunmountMountpointPodIfNeeded.This allows both paths to race on the same mount directory, where the dangling path can delete the directory while the normal path is still polling it.
This patch acquires the same per-pod lock in the dangling cleanup branch to serialize concurrent operations on the same Mountpoint Pod mount.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.