Skip to content

Fix dependencies for analyzing results from benchmarks #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Priyankakarumuru1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix dependencies for analyzing results from benchmarks #1737

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
798db01
Add analysis dependency group to benchmark pyproject.toml
Priyankakarumuru1 Jan 7, 2026
711bd84
Add analysis dependencies to dev group
Priyankakarumuru1 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions benchmark/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@ dependencies = [
dev = [
"pytest",
]
analysis = [
Copy link
Contributor

@sahityadg sahityadg Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried adding these to dev dependency-group like pytest?

That may be better as it won't need --group flag.

Copy link
Contributor Author

@Priyankakarumuru1 Priyankakarumuru1 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is actually much clear. I'll move omegaconf and tabulate to the dev group instead of creating a separate analysis group. Thanks for the suggestion!

Copy link
Contributor

@sahityadg sahityadg Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These dependencies are already defined here: https://github.com/awslabs/mountpoint-s3/blob/main/benchmark/analysis-scripts/autogroup.py#L3-L6. So uv should just install them anyway. We don't need them in pyproject.toml unless we want to move all dependencies here.

"omegaconf",
"tabulate",
]
Loading