Remove last usages of forbidden CI bucket#1782
Draft
dannycjones wants to merge 1 commit intoawslabs:mainfrom
Draft
Remove last usages of forbidden CI bucket#1782dannycjones wants to merge 1 commit intoawslabs:mainfrom
dannycjones wants to merge 1 commit intoawslabs:mainfrom
Conversation
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
force-pushed
the
remove-last-remnants-of-forbidden-bucket
branch
from
db1834f to
a50ceff
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
force-pushed
the
remove-last-remnants-of-forbidden-bucket
branch
from
a50ceff to
cf273cd
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we introduced the subsession IAM role for testing permissions in a flexible way, we relied on a "forbidden bucket" which has a bucket policy denying all S3 operations other than deletion of the bucket itself.
This change removes the last few dependencies on that bucket, such that the setup for running the integration tests is simpler.
Does this change impact existing behavior?
Existing tests are updated such that they no longer use the forbidden S3 bucket and instead use credentials from assuming a role.
Does this change need a changelog entry? Does it require a version change?
No, test change only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).