Fail benchmarks when a memory limit is breached - #1940
Open
renanmagagnin wants to merge 1 commit into
Open
Conversation
Signed-off-by: Renan Magagnin <renanmag@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory-limited benchmark jobs already report peak RSS breaches in a summary table but still pass. This makes a breach fail the job, after the results have been saved and published.
Testing:
render-mem-summary.shover 5 input shapes locally (no results, all within limit, partial breach, full breach) - correct output and exit code in each.falseand a skipped render step both pass; a breach still fails when an earlier step had already failed.--memory-targethas a 512 MiB floor.Supersedes #1935, which was auto-closed when its base branch was deleted. Same change, rebased onto
main.Does this change impact existing behavior?
Yes, intentionally: memory-limited benchmark jobs now fail on a breach. Results are still saved and published first, and other variants are unaffected.
Does this change need a changelog entry? Does it require a version change?
No, this only changes CI benchmark workflows.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).