Notebook: Databricks connector#128
Merged
andy-k-improving merged 15 commits intoft-hf-databricks-connector-feature-branchfrom Apr 8, 2026
Merged
Notebook: Databricks connector#128andy-k-improving merged 15 commits intoft-hf-databricks-connector-feature-branchfrom
andy-k-improving merged 15 commits intoft-hf-databricks-connector-feature-branchfrom
Conversation
mykola-pereyma
approved these changes
Apr 6, 2026
| ) | ||
|
|
||
|
|
||
| def get_athena_query_results( |
Collaborator
There was a problem hiding this comment.
@acarbonetto @andy-k-improving - we may need to release minor version to support Databricks notebook
Contributor
There was a problem hiding this comment.
Yes. 0.6.0 or something.
We can ask if this requires that we go through AppSec. I'm hoping we can skip the appsec review this time.
acarbonetto
approved these changes
Apr 7, 2026
Contributor
acarbonetto
left a comment
There was a problem hiding this comment.
Some small comments. Overall, the notebook looks good
Java module Move src Test file minimise dep Minimise dep Update changes Import driver Update code Update connection string Update header
# Conflicts: # .gitmodules # connectors/athena-databricks-connector/pom.xml # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java
# Conflicts: # connectors/athena-databricks-connector/athena-databricks-connector.yaml
Update notebook Update notebook Update dep Update notebook
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
90275cb to
01dfdb9
Compare
andy-k-improving
added a commit
that referenced
this pull request
Apr 9, 2026
* Init commit Java module Move src Test file minimise dep Minimise dep Update changes Import driver Update code Update connection string Update header * Folder restrcuture # Conflicts: # .gitmodules # connectors/athena-databricks-connector/pom.xml # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java * Update tests * SAM template # Conflicts: # connectors/athena-databricks-connector/athena-databricks-connector.yaml * Update doc * Databricks notebook Update notebook Update notebook Update dep Update notebook * Update notebook * Update testcase * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update doc * Make NEV optional --------- Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> # Conflicts: # pyproject.toml
andy-k-improving
added a commit
that referenced
this pull request
Apr 10, 2026
* Databricks connector - Module skeleton (#106) * Init commit Java module Move src Test file minimise dep Minimise dep Update changes Import driver Update code Update connection string Update header * Folder restrcuture * Update tests * Update Java doc * POM refactor * Update Readme * Databricks Connector - Deployment Instruction (#107) * SAM template # Conflicts: # connectors/athena-databricks-connector/athena-databricks-connector.yaml * Update template * Update docker file * Update doc * Update doc * Update doc * Update doc * Update doc * Databricks Connector - Metadatahandler (#108) * Update jdbc * Ignore git module changes Remove un compatible query Update API signature Update metadataHandler Update metdata Update wording * Update doc * Databricks connector - RecordHandler impelementation (#110) * Init commit Java module Move src Test file minimise dep Minimise dep Update changes Import driver Update code Update connection string Update header * Folder restrcuture # Conflicts: # .gitmodules # connectors/athena-databricks-connector/pom.xml # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java * Update tests * SAM template # Conflicts: # connectors/athena-databricks-connector/athena-databricks-connector.yaml * Update doc * Impl - Record handler Working copy Testable contructor Unit test Update record Make fetch size configable Update fetch size Update doc Update pushdown support Unit test * Update connectors/athena-databricks-connector/README.md Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update doc # Conflicts: # connectors/athena-databricks-connector/README.md --------- Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Notebook: Databricks connector (#128) * Init commit Java module Move src Test file minimise dep Minimise dep Update changes Import driver Update code Update connection string Update header * Folder restrcuture # Conflicts: # .gitmodules # connectors/athena-databricks-connector/pom.xml # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java * Update tests * SAM template # Conflicts: # connectors/athena-databricks-connector/athena-databricks-connector.yaml * Update doc * Databricks notebook Update notebook Update notebook Update dep Update notebook * Update notebook * Update testcase * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update notebooks/import_databricks_demo.ipynb Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update doc * Make NEV optional --------- Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> # Conflicts: # pyproject.toml * Databricks connector: Deployment instruction fixes (#130) * Init commit Java module Move src Test file minimise dep Minimise dep Update changes Import driver Update code Update connection string Update header * Folder restrcuture # Conflicts: # .gitmodules # connectors/athena-databricks-connector/pom.xml # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java # connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java * Update tests * SAM template # Conflicts: # connectors/athena-databricks-connector/athena-databricks-connector.yaml * Update doc * Databricks notebook Update notebook Update notebook Update dep Update notebook * Update testcase * Update jdbc string Update default option Update log stmt Reorder parameters Minimise diff * Update example host name * Update notebook * Connector: Directory restructure (#132) * Move s3 vector * Update path * Misc update * Update pyproject.toml Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Update connectors/athena-databricks-connector/src/main/resources/log4j2.xml Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Update connectors/athena-databricks-connector/Dockerfile Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Update connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Update connectors/athena-databricks-connector/athena-databricks-connector.yaml Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Update connectors/athena-databricks-connector/README.md Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Update connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java Co-authored-by: mykola-pereyma <pereymam@amazon.com> * Fix notebook * Update github action * Update doc * Update python * Update java * Update py test --------- Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: mykola-pereyma <pereymam@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a demo notebook for importing Databricks data into Neptune Analytics via Athena
Federation, along with a new get_athena_query_results utility function.
Changes
New: Databricks Import Demo Notebook
notebooks/import_databricks_demo.ipynb — End-to-end workflow demonstrating:
New: get_athena_query_results()
nx_neptune/instance_management.py — Fetches results for a completed Athena query by execution
ID. Paginates automatically. Returns raw rows (header + data) as list[list[str]].
Exported as public API in nx_neptune/init.py.
Tests
4 new tests for get_athena_query_results: single page, multi-page pagination, empty results,
default client creation.