Skip to content

Databricks connector: Deployment instruction fixes#130

Merged
andy-k-improving merged 9 commits intoft-hf-databricks-connector-feature-branchfrom
ft-hf-db-deployment-instruction
Apr 8, 2026
Merged

Databricks connector: Deployment instruction fixes#130
andy-k-improving merged 9 commits intoft-hf-databricks-connector-feature-branchfrom
ft-hf-db-deployment-instruction

Conversation

@andy-k-improving
Copy link
Copy Markdown
Contributor

This PR improves the deployment experience for the Databricks Athena connector by simplifying user inputs and reordering parameters for a more intuitive setup flow.

Simplified connection string setup

  • Users now provide just the Databricks hostname (e.g. dbc-1234567890.cloud.databricks.com) instead of the full JDBC connection string
  • DatabricksEnvironmentProperties automatically builds the default connection string from individual env vars (databricks_host, databricks_default_database, secret_manager_databricks_token_name)
  • Falls back gracefully if a default connection string is already present (e.g. via Glue connection)

SAM template improvements

  • Reordered parameters for better sam deploy --guided UX: connection details → infra config → optional tuning
  • Added DatabricksHost parameter with AllowedPattern validation to reject full URLs
  • Added AllowedPattern + ConstraintDescription on SpillBucket to prevent users entering S3 URIs or ARNs
  • Added Default: workspace for DatabricksConnCatalog

Centralised constants

  • Moved env var keys (secret_manager_databricks_token_name, databricks_default_database, databricks_host) into DatabricksConstants

README updates

  • Build command now uses mvn -f connectors/pom.xml so all commands run from repo root
  • Updated CloudFormation parameters table with DatabricksHost and improved SpillBucket description

Files changed

File Change
README.md Build command fix, parameters table update
athena-databricks-connector.yaml New DatabricksHost param, reordered params, SpillBucket validation
DatabricksConstants.java Added HOST_CONFIG_KEY, SECRET_NAME_CONFIG_KEY, DEFAULT_DATABASE_CONFIG_KEY
DatabricksEnvironmentProperties.java createEnvironment() override to build JDBC connection string from env vars

@andy-k-improving andy-k-improving changed the title Update jdbc string Databricks connector: Deployment instruction fixes Apr 6, 2026
@andy-k-improving andy-k-improving marked this pull request as ready for review April 6, 2026 22:25
Java module

Move src

Test file

minimise dep

Minimise dep

Update changes

Import driver

Update code

Update connection string

Update header
# Conflicts:
#	.gitmodules
#	connectors/athena-databricks-connector/pom.xml
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java
# Conflicts:
#	connectors/athena-databricks-connector/athena-databricks-connector.yaml
Update notebook

Update notebook

Update dep

Update notebook
Update default option

Update log stmt

Reorder parameters

Minimise diff
@andy-k-improving andy-k-improving force-pushed the ft-hf-db-deployment-instruction branch from 47d1877 to cfc524c Compare April 8, 2026 19:41
@andy-k-improving andy-k-improving changed the base branch from ft-hf-db-notebook to ft-hf-databricks-connector-feature-branch April 8, 2026 19:42
@andy-k-improving andy-k-improving merged commit b8f684c into ft-hf-databricks-connector-feature-branch Apr 8, 2026
@andy-k-improving andy-k-improving deleted the ft-hf-db-deployment-instruction branch April 8, 2026 23:18
andy-k-improving added a commit that referenced this pull request Apr 9, 2026
* Init commit

Java module

Move src

Test file

minimise dep

Minimise dep

Update changes

Import driver

Update code

Update connection string

Update header

* Folder restrcuture

# Conflicts:
#	.gitmodules
#	connectors/athena-databricks-connector/pom.xml
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java

* Update tests

* SAM template

# Conflicts:
#	connectors/athena-databricks-connector/athena-databricks-connector.yaml

* Update doc

* Databricks notebook

Update notebook

Update notebook

Update dep

Update notebook

* Update testcase

* Update jdbc string

Update default option

Update log stmt

Reorder parameters

Minimise diff

* Update example host name
andy-k-improving added a commit that referenced this pull request Apr 10, 2026
* Databricks connector - Module skeleton (#106)

* Init commit

Java module

Move src

Test file

minimise dep

Minimise dep

Update changes

Import driver

Update code

Update connection string

Update header

* Folder restrcuture

* Update tests

* Update Java doc

* POM refactor

* Update Readme

* Databricks Connector - Deployment Instruction (#107)

* SAM template

# Conflicts:
#	connectors/athena-databricks-connector/athena-databricks-connector.yaml

* Update template

* Update docker file

* Update doc

* Update doc

* Update doc

* Update doc

* Update doc

* Databricks Connector - Metadatahandler (#108)

* Update jdbc

* Ignore git module changes

Remove un compatible query

Update API signature

Update metadataHandler

Update metdata

Update wording

* Update doc

* Databricks connector - RecordHandler impelementation (#110)

* Init commit

Java module

Move src

Test file

minimise dep

Minimise dep

Update changes

Import driver

Update code

Update connection string

Update header

* Folder restrcuture

# Conflicts:
#	.gitmodules
#	connectors/athena-databricks-connector/pom.xml
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java

* Update tests

* SAM template

# Conflicts:
#	connectors/athena-databricks-connector/athena-databricks-connector.yaml

* Update doc

* Impl - Record handler

Working copy

Testable contructor

Unit test

Update record

Make fetch size configable

Update fetch size

Update doc

Update pushdown support

Unit test

* Update connectors/athena-databricks-connector/README.md

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update doc

# Conflicts:
#	connectors/athena-databricks-connector/README.md

---------

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Notebook: Databricks connector (#128)

* Init commit

Java module

Move src

Test file

minimise dep

Minimise dep

Update changes

Import driver

Update code

Update connection string

Update header

* Folder restrcuture

# Conflicts:
#	.gitmodules
#	connectors/athena-databricks-connector/pom.xml
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java

* Update tests

* SAM template

# Conflicts:
#	connectors/athena-databricks-connector/athena-databricks-connector.yaml

* Update doc

* Databricks notebook

Update notebook

Update notebook

Update dep

Update notebook

* Update notebook

* Update testcase

* Update notebooks/import_databricks_demo.ipynb

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update notebooks/import_databricks_demo.ipynb

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update notebooks/import_databricks_demo.ipynb

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update notebooks/import_databricks_demo.ipynb

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update notebooks/import_databricks_demo.ipynb

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update doc

* Make NEV optional

---------

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
# Conflicts:
#	pyproject.toml

* Databricks connector: Deployment instruction fixes (#130)

* Init commit

Java module

Move src

Test file

minimise dep

Minimise dep

Update changes

Import driver

Update code

Update connection string

Update header

* Folder restrcuture

# Conflicts:
#	.gitmodules
#	connectors/athena-databricks-connector/pom.xml
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksEnvironmentProperties.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksMetadataHandler.java
#	connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java

* Update tests

* SAM template

# Conflicts:
#	connectors/athena-databricks-connector/athena-databricks-connector.yaml

* Update doc

* Databricks notebook

Update notebook

Update notebook

Update dep

Update notebook

* Update testcase

* Update jdbc string

Update default option

Update log stmt

Reorder parameters

Minimise diff

* Update example host name

* Update notebook

* Connector: Directory restructure (#132)

* Move s3 vector

* Update path

* Misc update

* Update pyproject.toml

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Update connectors/athena-databricks-connector/src/main/resources/log4j2.xml

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Update connectors/athena-databricks-connector/Dockerfile

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Update connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksCompositeHandler.java

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Update connectors/athena-databricks-connector/athena-databricks-connector.yaml

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Update connectors/athena-databricks-connector/README.md

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Update connectors/athena-databricks-connector/src/main/java/com/amazonaws/athena/connectors/databricks/DatabricksRecordHandler.java

Co-authored-by: mykola-pereyma <pereymam@amazon.com>

* Fix notebook

* Update github action

* Update doc

* Update python

* Update java

* Update py test

---------

Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: mykola-pereyma <pereymam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants