chore: add usage metric identifiers to cloudformation stack descriptions #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 95.74% 95.80% +0.06%
==========================================
Files 42 45 +3
Lines 5361 5511 +150
Branches 684 693 +9
==========================================
+ Hits 5133 5280 +147
- Misses 221 224 +3
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cogwirrel
force-pushed
the
chore/metrics
branch
from
3ffe7cd to
3328c0f
Compare
agdimech
previously approved these changes
Mar 27, 2025
In order to help us improve the Nx Plugin for AWS, we collect metrics on generator usage. This process involves no additional network requests, we simply leverage existing AWS usage metrics. We append an ID, version, and list of generator IDs to CloudFormation Stack descriptions. This is done in the `MetricsAspect` in `common/constructs`.
cogwirrel
force-pushed
the
chore/metrics
branch
from
3328c0f to
ff9601b
Compare
agdimech
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
In order to help us improve the Nx Plugin for AWS, we collect metrics on generator usage.
Description of changes
This process involves no additional network requests, we simply leverage existing AWS usage metrics. We append an ID, version, and list of generator IDs to CloudFormation Stack descriptions. This is done in the
MetricsAspectincommon/constructs.Description of how you validated changes
Unit tests and tested in an example project
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license