Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infra): include namespace in application stack id #130

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

cogwirrel
Copy link
Contributor

Reason for this change

In order to better identify AWS resources, we prefix the stack id with the project namespace.

Description of changes

  • Prefix stack id with npm scope (this will be monorepo if there's no root package.json scope).
  • Updated load:runtime-config task to use the updated stack id
  • Updated the dungeon adventure tutorial to reflect the new stack id

Description of how you validated changes

Tested in a local project

Issue # (if applicable)

Fixes #85

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

In order to better identify AWS resources, we prefix the stack id with the project namespace.

Fixes #85
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (f2e7dba) to head (db12ae3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          42       42           
  Lines        5361     5364    +3     
  Branches      684      684           
=======================================
+ Hits         5133     5136    +3     
  Misses        221      221           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cogwirrel cogwirrel merged commit c222ecf into main Mar 27, 2025
6 checks passed
@cogwirrel cogwirrel deleted the fix/infra-namespace branch March 27, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generated infra stack should be prefixed with namespace
3 participants