Merged
Conversation
Introduces a "Best Practices" sidebar section and a new "Docker bundling" page that describes the bundle target + minimal Dockerfile + docker target pattern used by ts#strands-agent and py#strands-agent, and shows how to wire the resulting build context to CDK's DockerImageAsset or a Terraform null_resource publishing to ECR. Closes #328
Contributor
|
📚 Documentation translations have been updated and committed (9ea60a6) to this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 89.02% 89.02%
=======================================
Files 106 106
Lines 3443 3443
Branches 747 747
=======================================
Hits 3065 3065
Misses 174 174
Partials 204 204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cogwirrel
reviewed
Apr 21, 2026
- Pin the ADOT npm version in the Dockerfile example and add a tip about pinning dependencies and base image tags for reproducible builds - Move the RUN npm install step above COPY so the install layer is cached independently of the bundle output - Note that docker build is optional when deploying with CDK - Import findWorkspaceRoot from :my-scope/common-constructs and mention the alternative of hardcoding the workspace-relative path - Drop the definite article in "Running bundle before synth/apply" - Use nx apply in the Terraform note - Merge the CDK and Terraform sections into a single top-level Infrastructure heading, since the wiring is identical across TypeScript and Python - Mention "generator" explicitly in Further Reading links
Contributor
|
📚 Documentation translations have been updated and committed (10da405) to this PR. |
Contributor
|
📚 Documentation translations have been updated and committed (d3da0b9) to this PR. |
cogwirrel
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
ts#strands-agentandpy#strands-agentgenerators tackle a few gotchas when bundling application code and deploying it as a Docker image to ECR. That pattern (a cachedbundletarget that produces a self-contained directory, a minimalDockerfilethat simplyCOPYs it, and adockertarget that assembles the build context indist) is generally useful outside of AgentCore — for example for FastAPI on ECS — but until now it was not documented.Description of changes
/guides/docker-bundling) describing the pattern with separate TypeScript and Python sections. The guide covers:bundletarget (Rolldown for TypeScript,uv export+uv pip installfor Python).DockerfilethatCOPYs the bundle, plusRUN npm installfor TypeScript packages declared asexternalinrolldown.config.ts.dockertarget that copies theDockerfilealongside the bundle output and runsdocker build.DockerImageAsset, or to anaws_ecr_repository+null_resourceTerraform module that publishes to ECR.Description of how you validated changes
pnpm nx run docs:build) and confirmed the new page is emitted for all locales and that link validation passes.ts#strands-agentandpy#strands-agentgenerators (packages/nx-plugin/src/ts/strands-agent/generator.ts,packages/nx-plugin/src/py/strands-agent/generator.ts,packages/nx-plugin/src/utils/bundle/bundle.ts, and the deploy Dockerfile templates) to confirm the commands and infrastructure snippets match what the generators produce today.Issue # (if applicable)
Closes #328.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license