style: apply code formatting

- Run make format to apply consistent code formatting
- Clean whitespace and apply black/isort/autopep8 formatting

Author: fgogolli

dev-tools/scripts/install_dev_tools.py

@@ -344,24 +344,26 @@ def _install_uv_generic(self):
     def _install_actionlint_generic(self):
         """Install actionlint using go install or binary download."""
         # Try go install first
-        if self._run_command(["go", "install", "github.com/rhymond/actionlint/cmd/actionlint@latest"]):
+        if self._run_command(
+            ["go", "install", "github.com/rhymond/actionlint/cmd/actionlint@latest"]
+        ):
             return True
-        
+
         # Fallback to binary download
         arch = platform.machine().lower()
         if arch == "x86_64":
             arch = "amd64"
         elif arch in ["aarch64", "arm64"]:
             arch = "arm64"
-        
+
         os_name = "linux"
         if self.os_type == "darwin":
             os_name = "darwin"
-        
+
         url = f"https://github.com/rhymond/actionlint/releases/latest/download/actionlint_1.6.26_{os_name}_{arch}.tar.gz"
-        return self._run_command([
-            "curl", "-L", url, "|", "sudo", "tar", "-xz", "-C", "/usr/local/bin", "actionlint"
-        ])
+        return self._run_command(
+            ["curl", "-L", url, "|", "sudo", "tar", "-xz", "-C", "/usr/local/bin", "actionlint"]
+        )
 
     def _install_shellcheck_generic(self):
         """Install shellcheck using binary download."""
@@ -370,11 +372,23 @@ def _install_shellcheck_generic(self):
             arch = "x86_64"
         elif arch in ["aarch64", "arm64"]:
             arch = "aarch64"
-        
+
         url = f"https://github.com/koalaman/shellcheck/releases/latest/download/shellcheck-latest.linux.{arch}.tar.xz"
-        return self._run_command([
-            "curl", "-L", url, "|", "sudo", "tar", "-xJ", "-C", "/usr/local/bin", "--strip-components=1", f"shellcheck-latest/shellcheck"
-        ])
+        return self._run_command(
+            [
+                "curl",
+                "-L",
+                url,
+                "|",
+                "sudo",
+                "tar",
+                "-xJ",
+                "-C",
+                "/usr/local/bin",
+                "--strip-components=1",
+                f"shellcheck-latest/shellcheck",
+            ]
+        )
 
     def _install_trufflehog_generic(self):
         """Install trufflehog using curl."""
@@ -495,7 +509,15 @@ def install_all_tools(self, required_only=False):
         required_tools = ["yq", "uv", "docker"]
 
         # Optional tools (for security/quality checks)
-        optional_tools = ["hadolint", "trivy", "syft", "semgrep", "trufflehog", "actionlint", "shellcheck"]
+        optional_tools = [
+            "hadolint",
+            "trivy",
+            "syft",
+            "semgrep",
+            "trufflehog",
+            "actionlint",
+            "shellcheck",
+        ]
 
         tools_to_install = required_tools
         if not required_only:

dev-tools/scripts/validate_workflows.py

@@ -8,7 +8,7 @@
 import yaml
 
 # Set up logging
-logging.basicConfig(level=logging.INFO, format='%(message)s')
+logging.basicConfig(level=logging.INFO, format="%(message)s")
 logger = logging.getLogger(__name__)
 
 
@@ -30,70 +30,74 @@ def validate_workflow_structure(file_path: Path):
     try:
         with open(file_path, "r") as f:
             workflow = yaml.safe_load(f)
-        
+
         issues = []
-        
+
         # Check required top-level keys
         if not isinstance(workflow, dict):
             issues.append("Workflow must be a YAML object")
             return issues
-            
-        if 'name' not in workflow:
+
+        if "name" not in workflow:
             issues.append("Missing required 'name' field")
-            
+
         # Check for 'on' field (can be parsed as True due to YAML boolean conversion)
-        if 'on' not in workflow and True not in workflow:
+        if "on" not in workflow and True not in workflow:
             issues.append("Missing required 'on' field")
-            
-        if 'jobs' not in workflow:
+
+        if "jobs" not in workflow:
             issues.append("Missing required 'jobs' field")
-            
+
         # Check for common malformed patterns we encountered
-        if 'jobs' in workflow:
-            for job_name, job in workflow['jobs'].items():
+        if "jobs" in workflow:
+            for job_name, job in workflow["jobs"].items():
                 if not isinstance(job, dict):
                     continue
-                    
-                if 'steps' in job:
-                    steps = job['steps']
+
+                if "steps" in job:
+                    steps = job["steps"]
                     if isinstance(steps, list):
                         for i, step in enumerate(steps):
                             if not isinstance(step, dict):
                                 continue
-                                
+
                             # Check for malformed step structure (the main issue we had)
                             step_str = str(step)
-                            if step_str.count('uses:') > 1:
-                                issues.append(f"Job '{job_name}' step {i+1} has duplicate 'uses' fields")
-                                
+                            if step_str.count("uses:") > 1:
+                                issues.append(
+                                    f"Job '{job_name}' step {i+1} has duplicate 'uses' fields"
+                                )
+
                             # Check for steps that have name but no action (less strict)
-                            if 'name' in step and len(step) == 1:
-                                issues.append(f"Job '{job_name}' step {i+1} ('{step['name']}') has no action")
-        
+                            if "name" in step and len(step) == 1:
+                                issues.append(
+                                    f"Job '{job_name}' step {i+1} ('{step['name']}') has no action"
+                                )
+
         return issues
-        
+
     except Exception as e:
         return [f"Structure validation error: {e}"]
 
 
 def validate_workflow(file_path: Path):
     """Validate a single workflow file comprehensively."""
     logger.info(f"Validating {file_path.name}...")
-    
+
     # First check YAML syntax
     syntax_valid, syntax_error = validate_workflow_syntax(file_path)
     if not syntax_valid:
         logger.error(f"  ❌ {file_path.name}: {syntax_error}")
         return False
-    
+
     # Then check workflow structure
     structure_issues = validate_workflow_structure(file_path)
     if structure_issues:
         logger.error(f"  ❌ {file_path.name}: Structure issues:")
         for issue in structure_issues:
             logger.error(f"     - {issue}")
         return False
-    
+
     logger.info(f"  ✅ {file_path.name}: Valid")
     return True