fix: allow PENDING→COMPLETE transition and idempotent status updates, fix LT tag embedding

Author: fgogolli

src/orb/domain/request/request_types.py

@@ -133,11 +133,17 @@ def can_transition_to(self, new_status: RequestStatus) -> bool:
         Returns:
             True if transition is valid, False otherwise
         """
+        # Idempotent transitions are always valid (same status → same status)
+        if new_status == self:
+            return True
+
         valid_transitions = {
             RequestStatus.PENDING: [
                 RequestStatus.IN_PROGRESS,
                 RequestStatus.CANCELLED,
                 RequestStatus.FAILED,
+                RequestStatus.COMPLETED,  # instant provisioning (e.g. RunInstances)
+                RequestStatus.PARTIAL,    # instant provisioning with partial fulfillment
             ],
             RequestStatus.IN_PROGRESS: [
                 RequestStatus.COMPLETED,

src/orb/providers/aws/infrastructure/launch_template/manager.py

@@ -438,11 +438,16 @@ def _create_new_launch_template(
             "Launch template %s does not exist. Creating new template.", template_name
         )
 
+        lt_tags = self._create_launch_template_tags(aws_template, request)
+
         response = self.aws_client.ec2_client.create_launch_template(
             LaunchTemplateName=template_name,
             VersionDescription=f"Created for request {request.request_id}",
             LaunchTemplateData=template_data,
             ClientToken=client_token,  # Key for idempotency!
+            TagSpecifications=[
+                {"ResourceType": "launch-template", "Tags": lt_tags}
+            ],
         )
 
         launch_template = response["LaunchTemplate"]