Conversation
5a4d5e8 to
342bc67
Compare
342bc67 to
3ff9239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
UI Modernization & Feature Popup Redesign
Summary
Complete overhaul of the OSML Cesium Globe UI -- replacing the CloudScape design system with a custom glass-morphism dark theme, removing default Cesium widgets, adding cinematic globe enhancements, and redesigning the feature click popup as a rich HTML overlay.
Changes
Design System Migration
@cloudscape-design/components,@cloudscape-design/global-styles,@cloudscape-design/component-toolkit) entirely frompackage.json-- the enterprise-style components clashed with the dark globe aesthetic and caused styling issues (e.g., white-on-white dropdowns in portals).DarkModal.tsx/DarkModal.css) with glass-morphism panels, backdrop blur, entrance animations, header/body/footer layout, and tab support.FormControls.tsx/FormControls.css) replacing CloudScape inputs:DarkFormField,DarkInput,DarkAutosuggest,DarkSelect(withrenderOption/renderValuesupport for color swatches), andDarkMultiselect-- all with filtering, keyboard navigation, loading/error states, and outside-click dismissal.ImageRequestModal,LoadDataModal,LoadImageModal) to use the new custom components with zero CloudScape imports.CredsExpiredAlert,ImageRequestStatus) from CloudScapeAlertwrappers to custom glass-morphism toast cards with color-coded status, animated spinners, and CSS-driven hover/transitions.S3DataSelector,S3ImageSelector,LocalDataSelector,NewRequestButton) that were made redundant by the unifiedOsmlMenupanel.OSML Menu Panel
OsmlMenu.tsx/OsmlMenu.css) with a hamburger toggle button, animated panel open/close, action cards (Submit Request, Load GeoJSON, Load Image), and a grouped layer list with visibility/zoom/remove controls.ResourceContext(ResourceContext.tsx) providingaddResource,removeResource,toggleVisibility,zoomTo, andclearAlloperations with proper Cesium viewer integration.Cesium Viewer Enhancements
baseLayerprop is set once (no recreation warning).showGroundAtmosphere,enableLighting, sky atmosphere, sun rendering, and subtle distance fog via an imperative viewer ref callback.styles.css: removed ~100 lines of CloudScape override hacks.Logo Polish
clamp(40px, 6vh, 70px)instead of fixed10vh.Status Card Transitions
ImageRequestStatusrewritten with a dedicated CSS file (ImageRequestStatus.css).Feature Popup Redesign
FeaturePopup.tsx/FeaturePopup.css: a glass-morphism HTML overlay that replaces the old Cesium billboard + plain-text label.SceneTransforms.worldToWindowCoordinateson eachpreRenderframe.formatFeaturePropertiesincesiumHelper.tsfrom returning a flat string to returning structuredPropertyGroup[]data with recursivePropertyEntryobjects (supportingchildren).cesiumHelper.tsnow accepts anonFeatureClickcallback threaded fromApp.tsxthroughOsmlTray->OsmlMenu-> modals ->loadGeoJson/loadS3GeoJson. The billboard marker is kept; the Cesium label is removed.iri/scoreproperties from the object instead of regex-splitting a flattened string.Color Swatch Previews
DarkSelectextended withrenderOptionandrenderValueprops.ImageRequestModalnow shows a colored circle next to each color name in both the dropdown and the selected value.Files Changed
DarkModal.tsx/css,FormControls.tsx/css(new)ImageRequestModal.tsx,LoadDataModal.tsx,LoadImageModal.tsxOsmlMenu.tsx/css(new),OsmlTray.tsxCredsExpiredAlert.tsx,ImageRequestStatus.tsx/cssFeaturePopup.tsx/css(new),cesiumHelper.tsApp.tsx,main.tsx,styles.css,Logo.cssResourceContext.tsx(new)S3DataSelector,S3ImageSelector,LocalDataSelector,NewRequestButtonpackage.json(-3 CloudScape packages)Checklist
Before you submit a pull request, please make sure you have the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.