Skip to content

Conversation

drduhe
Copy link
Collaborator

@drduhe drduhe commented Sep 17, 2025

Issue #, if available: n/a

Notes

Implements ship detection model for OSML, adding a new model alongside the existing aircraft detection model.

Changes

  • New ship detection model with complete implementation (src/aws/osml/models/ship/)
  • Model weights for both aircraft and ship detection added to assets
  • LFS tracking configured for large model files (.pth)
  • Aircraft model fix to use correct weights filename

Files Added/Modified

  • src/aws/osml/models/ship/app.py - Main ship detection application
  • src/aws/osml/models/ship/config.py - Ship model configuration
  • src/aws/osml/models/ship/__init__.py - Package initialization
  • assets/ship_model_weights.pth - Ship model weights
  • assets/aircraft_model_weights.pth - Aircraft model weights
  • .gitattributes - LFS tracking configuration
  • src/aws/osml/models/aircraft/app.py - Fixed weights filename reference

Impact

  • Adds ship detection capability to the OSML model suite
  • Maintains backward compatibility with existing aircraft model
  • Properly handles large model files with Git LFS

Checklist

Before you submit a pull request, please make sure you have the following:

  • Code changes are compact and well-structured to facilitate easy review
  • Changes are documented in the README.md and other relevant documentation pages
  • PR title and description accurately reflect the changes and are detailed enough for historical tracking
  • PR contains tests that cover all new code and the code has been manual tested
  • All new dependencies are declared (if any), and no unnecessary libraries are added
  • Performance impacts (if any) of the changes are evaluated and documented
  • Security implications of the changes (if any) are reviewed and addressed
  • I have read the Contributing Guidelines and agree to follow the Code of Conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@drduhe drduhe closed this Sep 17, 2025
@drduhe drduhe deleted the feat/implement-ship-model-fixed branch September 17, 2025 17:44
@drduhe drduhe restored the feat/implement-ship-model-fixed branch September 17, 2025 17:45
@drduhe drduhe reopened this Sep 17, 2025
@drduhe drduhe force-pushed the feat/implement-ship-model-fixed branch from ae74458 to 73c0938 Compare September 17, 2025 17:53
@drduhe drduhe force-pushed the feat/implement-ship-model-fixed branch 7 times, most recently from 5f12059 to d0e7cd6 Compare September 24, 2025 17:59
@drduhe drduhe force-pushed the feat/implement-ship-model-fixed branch 3 times, most recently from cd1a9ba to 8ab143d Compare September 24, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant