Open
Conversation
phdum-a
force-pushed
the
phdum/multi_excitation
branch
3 times, most recently
from
0bbd871 to
04a6a38
Compare
phdum-a
force-pushed
the
phdum/multi_excitation
branch
2 times, most recently
from
576db7f to
9a8b33a
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
1345ffc to
99faed2
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
3 times, most recently
from
4f9dcd1 to
1de618d
Compare
hughcars
force-pushed
the
phdum/prom_synthesis
branch
from
1de618d to
777dbba
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
777dbba to
8410b5b
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
8410b5b to
645e19f
Compare
hughcars
force-pushed
the
phdum/prom_synthesis
branch
2 times, most recently
from
00c89d6 to
6dea781
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
6dea781 to
06c680d
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
06c680d to
70f588c
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
5 times, most recently
from
1e98f37 to
10a0443
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
10a0443 to
f9691b4
Compare
hughcars
reviewed
Oct 2, 2025
Collaborator
hughcars
left a comment
hughcars
left a comment
There was a problem hiding this comment.
Took a quick look whilst waiting on your fixes on the normalization.
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
f9691b4 to
eef61b9
Compare
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
3 times, most recently
from
1b98be6 to
f94f27f
Compare
- move to test-romoperator.cpp from test-drivensolver.cpp
- Better accuracy and reasonably cheap on small ROM size
- Use clang-tidy misc-include-cleaner to find unused includes - Adjust clang-tidy options
…ommit - Make InnerProductStandard a functor which is thread local. Orthogonalization routines now always include reduction. - Make InnerProductHybridBulkBoundary into HybridBulkBoundaryOperator that is "matrix-like" but not the inner product operator. Remove internal workspace. - Wrapper HybridBulkBoundaryOperator in lambda at OrthogonalizeColumn call-site. - Adjust tests.
phdum-a
force-pushed
the
phdum/prom_synthesis
branch
from
d62e4ab to
3b6fb23
Compare
This was referenced Feb 6, 2026
- Separate PROM orthogonalization option from linear solver option. Default to CGS2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obtain circuit from PROM operator.
Draft: Pending #302, #309 merges and expecting follow up changes from those.