-
Notifications
You must be signed in to change notification settings - Fork 85
Update hypre, MFEM, PETSC, and SELPc #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3593bd4 to
037c69f
Compare
cameronrutherford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback. Overall great! 🥳
037c69f to
91a3774
Compare
|
Hi all, sorry for chiming in! Just wanted to note that hypre is moving to CMake as its recommended build system starting from hypre 3. Currently, hypre's CMake supports all build options that autotools' configure does and a few more. Build times is also generally faster with hypre's CMake |
bc40541 to
c038ef6
Compare
The tagged commit for `hypre` is incompatible with CUDA 13, so that Palace does not compile with the latest version of the CUDA toolkit. This commit updates a few packages to their latest versions and adds a new dependency on Umpire. Umpire is strongly recommended for hypre 3 with CUDA. Similar to magma, umpire is automatically added to the build when buidling with CUDA or HIP.
e367d82 to
4e6dd67
Compare
4e6dd67 to
5fc09ff
Compare
|
I did more extensive testing of this PR and found that my previous implementation broke shared builds. This is due to a transitive dependency ( Some followup work that will be left is:
|
7027a99 to
c0bbfdb
Compare
PR #519 is almost ready, but it uncovered a couple of possible problems. For this reason, we might want to be cautious with it. One of the key benefits of PR #519 is that it brings compatibility with CUDA 13 and with CUDA 12.9 + GCC 14. This PR does not fix compatibility with CUDA 13, but it does for CUDA 12.9 + GCC 14.
I looked a little bit into this. I found that the crash occurs at in |
The tagged commit for
hypreis incompatible with CUDA 13, so that Palace does not compile with the latest version of the CUDA toolkit.This commit updates a few packages to their latest versions and adds a new dependency on Umpire. Umpire is strongly recommended for hypre 3 with CUDA. I also switch to using CMake instead of autotools in hypre and not use the internal hypre device manager.
Similar to magma, umpire is automatically added to the build when buidling with CUDA or HIP.
Closes #498
Spack build in docs depends on spack/spack-packages#1855 (or on pushing the package.py to spack-packages)