Surface try_compile/try_run errors in CMake configure output#650
Draft
Surface try_compile/try_run errors in CMake configure output#650
Conversation
hughcars
force-pushed
the
hughcars/surface-try-compile-errors
branch
from
d6d78c3 to
792a5e4
Compare
When PETSc, SLEPc, or std::filesystem test programs fail to compile or run, the actual error was hidden in CMakeConfigureLog.yaml. Print the compile or run output to the main log on failure, matching the pattern already used by the libCEED test. Closes #649
hughcars
force-pushed
the
hughcars/surface-try-compile-errors
branch
from
792a5e4 to
927e271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When PETSc, SLEPc, or std::filesystem test programs fail during configure, the error is hidden in
CMakeConfigureLog.yaml. The user only sees:This prints the actual compiler/linker error (or runtime error) to the main configure log on failure. The libCEED check already did this; PETSc, SLEPc, and std::filesystem did not.
Closes #649