Draft
Conversation
And remove patch that was merged
Sbozzolo
added
draft
Sbozzolo
force-pushed
the
gbozzola/spack
branch
from
78e057e to
d239245
Compare
hughcars
approved these changes
Mar 10, 2026
Collaborator
hughcars
left a comment
hughcars
left a comment
There was a problem hiding this comment.
Do you think this should come before or after the spack-repo one. Happy to merge this first, and then we can follow up if they give more feedback in a later MR.
Member
Author
I was thinking after so that we can make sure we are synced with the feedback from spack-packages (if any) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove patch that was merged
xref: spack/spack-packages#3668