Skip to content

Fix driven solver SurfaceCurrent with no pre-existing excitation #661

Open
phdum-a wants to merge 2 commits intomainfrom
phdum/fix_current_op_no_excitation
Open

Fix driven solver SurfaceCurrent with no pre-existing excitation #661
phdum-a wants to merge 2 commits intomainfrom
phdum/fix_current_op_no_excitation

Conversation

@phdum-a
Copy link
Contributor

@phdum-a phdum-a commented Mar 9, 2026

Closes #616.

SurfaceCurrent can be used in the driven solver, but don't have any "Excitation" index. Instead they are added to all excitations. There is a bug where if there is no already existing excitation, this fails.

More generally, the Excitation interface was only designed for lumped or wave ports even through there are other times of excitations (like SurfaceCurrent, Dipole, etc) and this should be reworked to be more general and user friendly.

@phdum-a phdum-a requested review from Sbozzolo and hughcars March 9, 2026 21:07
@phdum-a phdum-a changed the title Phdum/fix current op no excitation Fix driven solver SurfaceCurrent with no pre-existing excitation Mar 9, 2026
@phdum-a phdum-a added the no-long-tests This PR does not require the long tests to be merged label Mar 9, 2026
@phdum-a phdum-a marked this pull request as ready for review March 9, 2026 23:33
@Sbozzolo
Copy link
Member

Do you maybe want to add some of the (very useful) content of #616 (comment) in the documentation?

@phdum-a
Copy link
Contributor Author

phdum-a commented Mar 10, 2026

Do you maybe want to add some of the (very useful) content of #616 (comment) in the documentation?

Happy to, but could you let me know what parts in particular? I think that everything I have written is already in the documentation in https://awslabs.github.io/palace/dev/guide/boundaries/ and https://awslabs.github.io/palace/dev/reference/

@Sbozzolo
Copy link
Member

Do you maybe want to add some of the (very useful) content of #616 (comment) in the documentation?

Happy to, but could you let me know what parts in particular? I think that everything I have written is already in the documentation in https://awslabs.github.io/palace/dev/guide/boundaries/ and https://awslabs.github.io/palace/dev/reference/

I find that your comment provides insight on how the features should be used, not just a description of the math/interface (e.g, you describe the difference between LumpedPort and SurfaceCurrent from a modeling/physics perspective). I also don't see references to dissipation or even the different normalizations in the boundaries page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-long-tests This PR does not require the long tests to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Help with using SurfaceCurrent as excitation source in Driven simulations

3 participants