Loosen test tolerance in OrthogonalizeColumn by 10x#672
Open
Conversation
- Intel optimizers (non-consistently) goes above original tolerance in tests
phdum-a
added
the
no-long-tests
hughcars
approved these changes
Mar 12, 2026
Member
|
Interestingly, clang is failing in this build https://github.com/awslabs/palace/actions/runs/23026967274/job/66876966711?pr=672 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #671
Factor 10 should be enough. From #671:
(0.00052872439846396 - 0.00052872439846385) / 0.00052872439846385 = 2.0805×10⁻¹³
While:
1000 * std::numeric_limits::epsilon() = 2.220446049250313e-13
However, given how small this problem is (3x3 matrix on 1 rank), the loss of precision here is really not great and maybe something to study in more detail.