Add ARM release workflow#1474
Merged
Merged
Conversation
github-actions
Bot
added
the
github_actions
sondavidb
force-pushed
the
add-arm-release-workflow
branch
4 times, most recently
from
a32261a to
492c4a4
Compare
Contributor
Author
|
It's worth noting that with this artifact generation the glibc version used to generate the artifacts might differ. Probably not a big deal, but also probably worth noting. |
sondavidb
force-pushed
the
add-arm-release-workflow
branch
from
492c4a4 to
8a0884d
Compare
Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
add-arm-release-workflow
branch
from
8a0884d to
5a5df72
Compare
Kern--
approved these changes
Apr 18, 2025
austinvazquez
approved these changes
May 28, 2025
Contributor
There was a problem hiding this comment.
LGTM, sorry for the delay. @sondavidb , this is fine to bring in now?
Contributor
Author
Should be 🤞 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Final part of #447
Description of changes:
While x86 release binaries were already automated, GitHub Actions does not have native ARM support so we have been manually creating those. This PR should allow for automatic ARM artifact release generation.
This was achieved by moving the
build.ymlsetup into a new filesetup.ymlso that it can be reused between the Build and Release workflows.With this, our release process should only be, creating a branch, adding the third-party licenses, and pushing the tag. From there the automation should do the rest.
Testing performed:
Created my own tag locally which created this dummy release (GitHub Actions run here).
I haven't tested publishing for multiple architectures yet, but that section is based on actions/download-artifact's README, so I think it should be right?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.