Add SOCI conversion#1522
Merged
Merged
Conversation
Kern--
force-pushed
the
conversion
branch
3 times, most recently
from
3df8c4c to
affaafb
Compare
github-actions
Bot
added
go
This chnage uses the containerd content store for the SOCI CLI. SOCI indexes will be tied to the image lifecycle and will get automtaically garbage collected when the image is removed. The snapshotter still uses the local soci content store by default until we're confident that the circular reference back to contaienrd is safe. Signed-off-by: Kern Walster <walster@amazon.com>
Kern--
force-pushed
the
conversion
branch
3 times, most recently
from
a8de399 to
bbd4825
Compare
coderbirju
reviewed
Apr 28, 2025
sondavidb
previously approved these changes
Apr 30, 2025
Contributor
sondavidb
left a comment
sondavidb
left a comment
There was a problem hiding this comment.
Generally LGTM, all my comments are OK to address in a followup PR.
Before this change, tests that verify invalid ztocs ingested the ztoc into the containerd content store, then applied a root gc label. This introduced a race condition where the content could be gc'd after ingestion, but before labelling leading to flakey tests and missing content. This change makes ingestion require a parent content object which will get a gc label before ingestion. This guarantees that the newly ingested content will not be gc'd because there it already has a path to a gc root befor the ingestion happens. Signed-off-by: Kern Walster <walster@amazon.com>
This change adds a command to convert an image to a SOCI-enabled image which contains strong references to both the image and SOCI index in a logically single, deployable artifact. Signed-off-by: Kern Walster <walster@amazon.com>
sondavidb
approved these changes
Apr 30, 2025
Shubhranshu153
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change adds a command to convert an image to a SOCI-enabled image which contains strong references to both the image and SOCI index in a logically single, deployable artifact.
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.