Retornam/updates

[retornam]

Issue #, if available: N/A

Description of changes:

Upgrades containerd, nerdctl and runc in Dockerfile

Testing performed:

built Dockerfile locally and ran it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

✅ without objection so ordered.

[sondavidb]

Hi there @retornam, thanks for the contribution!

Few changes I'd like looked at before I can run the workflows:

1. nerdctl 2.0 is actually a breaking change, largely due to them allowing namespace at a more macro level. For this reason we've held off on upgrading for now (we have a PR that we closed a bit ago due to CI failures). That's not to say we don't want to upgrade per se but that it will require more effort than the usual version bump. Bumping it to the latest 1.x version (v1.7.7) should be harmless, though.
2. containerd bump to 1.7 is not strictly needed since our workflows already set the version number, but I could be convinced to bump it in our Dockerfile anyway to signal that it's the preferred version. (1.6 is planned to go EOL end of July anyway, so might as well?)
3. I like the formatting changes, but I think it might be nice to also follow it up by adding a Dockerfile linter to our workflows, so that we can ensure we continue to confirm to standards. Seems that https://github.com/hadolint/hadolint-action is a popular tool to achieve this. I'd prefer to group an update to linting our Dockerfile with a linter as well, but I'm OK taking that up as a followup instead (done by either me or you, whichever you prefer).

Thanks again!

[retornam]

@sondavidb first, thank you. I've resolved all the issues in the commits following your comments.

[sondavidb]

Thanks! Seems we're having a bit of trouble running the CI. We'll try a few stuff on our end to fix this. I'll be closing and reopening it just to see if that would work — sometimes that fixes some weird broken GitHub actions stuff. (EDIT: Looks like just closing and reopening it worked 🙂)

In the meantime @retornam would you mind squashing your commits? It's fine to have multiple commits if you want but generally we try to have one idea per commit. (If you want an opinion, I'd group all the version bumps into one commit, and the Dockerfile linting changes into another.)

[retornam]

@sondavidb thanks. I'll squash my commits, I added the newer ones to make it easier to review the changes based on your previous comments.

[sondavidb]

Yeah, the changes themselves look good, I'll get another reviewer once the commits are squashed

[retornam]

@sondavidb squashed into two commits.

[sondavidb]

Thanks @retornam, final thing could you just change the new squashed commit name to reflect the squashed changes? Probably something like "Bump Dockerfile versions" or something of the sort (currently a user might think this commit only bumps the containerd version when it changes more than that)

[retornam]

@sondavidb done.

[sondavidb]

The CI timeout seems unrelated to your changes, checked our GH Actions runs and seems like our integration tests have increased in time since late last week. All the other tests pass and time to run seems on par with the other GH Actions runs

[retornam]

@sondavidb thank you. A committer can now merge this since I dont have the power to.

[sondavidb]

@retornam Really sorry, I just took a look and it looks like hadolint is actually under GPL 3.0 (license file) so I don't think we can use that here. I should have checked the license before suggesting it, so that's my mistake.

I think if we just remove the commit adding the GH Action and stick with the Dockerfile updates I'll be happy with that. I can followup and add a different linter on my own time. You've already done a lot for us so I don't want to add more to the churn.

[retornam]

@sondavidb done