Fix config mediatype in Convert#1539
Merged
Merged
Conversation
github-actions
Bot
added
go
Converting an image to a soci-enabled image also converts docker v2 images to oci v1 images. Before this change, we didn't change the image config's mediatype meaning the image would claim it is an OCI v1 image while the config would claim it's a Docker v2 image. This caused some registries to interpret this as a non-image artifact. This change sets the config media type to be a OCI v1 config. Signed-off-by: Kern Walster <walster@amazon.com>
swagatbora90
approved these changes
May 1, 2025
sondavidb
approved these changes
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Converting an image to a soci-enabled image also converts docker v2 images to oci v1 images. Before this change, we didn't change the image config's mediatype meaning the image would claim it is an OCI v1 image while the config would claim it's a Docker v2 image. This caused some registries to interpret this as a non-image artifact. This change sets the config media type to be a OCI v1 config.
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.