Use default platform in convert#1557
Merged
Merged
Conversation
github-actions
Bot
added
go
Kern--
force-pushed
the
convert-platforms
branch
4 times, most recently
from
6e9c920 to
bc2b799
Compare
Shubhranshu153
previously approved these changes
May 21, 2025
sondavidb
reviewed
May 22, 2025
Shubhranshu153
previously approved these changes
May 22, 2025
Before this change, the SOCI cli defaulted to converting all platforms. This is inconsistent with nerdctl's pull, push, and convert functions. It also leads to weird issues like this not working: ``` nerdctl pull docker.io/library/busybox:latest soci convert docker.io/library/busybox:latest other:latest-soci ``` the solution is either to pull with `--all-platforms` or convert with `--platform`. The latter had an additional bug that convert touched all manifests, even if you didn't convert them. This change makes SOCI default to single platform conversions and fixes the manifests bug. SOCI convert now behaves like nerdctl pull/convert/push. Signed-off-by: Kern Walster <walster@amazon.com>
sondavidb
approved these changes
May 28, 2025
Shubhranshu153
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Before this change, the SOCI cli defaulted to converting all platforms. This is inconsistent with nerdctl's pull, push, and convert functions. It also leads to weird issues like this not working:
the solution is either to pull with
--all-platformsor convert with--platform. The latter had an additional bug that convert touched all manifests, even if you didn't convert them.This change makes SOCI default to single platform conversions and fixes the manifests bug. SOCI convert now behaves like nerdctl pull/convert/push.
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.