Update Push integration tests and remove --user flag

[prafgup]

Issue #, if available:
Followups from - #1866

Description of changes:
Removed --user from Push Integration test and changed image to alpine as per discussion here - https://github.com/awslabs/soci-snapshotter/pull/1866/changes#r2824641126

Testing performed:
Ran integration tests -

sudo GO_TEST_FLAGS="-run TestSociArtifactsPushAndPull  -count=1" make integration
cd cmd/ ; GO111MODULE=auto go build -o /Volumes/git/prafulg/soci-snapshotter/out/soci-snapshotter-grpc  -ldflags '-X github.com/awslabs/soci-snapshotter/version.Version=18083c98.m -X github.com/awslabs/soci-snapshotter/version.Revision=18083c989ba30fd33781cc1dddac651a63151ac1.m  -s -w '  ./soci-snapshotter-grpc
cd cmd/ ; GO111MODULE=auto go build -o /Volumes/git/prafulg/soci-snapshotter/out/soci  -ldflags '-X github.com/awslabs/soci-snapshotter/version.Version=18083c98.m -X github.com/awslabs/soci-snapshotter/version.Revision=18083c989ba30fd33781cc1dddac651a63151ac1.m  -s -w '  ./soci
integration
SOCI_SNAPSHOTTER_PROJECT_ROOT=/Volumes/git/prafulg/soci-snapshotter
=== RUN   TestSociArtifactsPushAndPull
=== RUN   TestSociArtifactsPushAndPull/amd64
=== RUN   TestSociArtifactsPushAndPull/arm64
--- PASS: TestSociArtifactsPushAndPull (12.35s)
    --- PASS: TestSociArtifactsPushAndPull/amd64 (5.63s)
    --- PASS: TestSociArtifactsPushAndPull/arm64 (5.58s)
PASS
ok      github.com/awslabs/soci-snapshotter/integration 127.211s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[prafgup]

@sondavidb 😄
Followups from - #1866

[sondavidb]

Thanks for this!

I took a look at the last few failures in our actions (1, 2, 3, 4, 5) and I don't think the failures are concentrated solely in the functions changed here.

I think there's a better mechanism we can use here to catch these retries as opposed to changing every single pull to a retry (e.g. rerunning only the tests that failed). I'm happy to just make the image changes and removing the --user flag usage.

[prafgup]

Ah, you are right, I see we use imagePullCmd at a lot of places where few of the failures were seen.

• soci-snapshotter/integration/util_test.go

  Line 86 in 01a89f7

  imagePullCmd = []string{"nerdctl", "pull", "-q", "--snapshotter", "soci"}

I see nerdctl pull does not have any inbuilt retry - https://github.com/containerd/nerdctl/blob/main/docs/command-reference.md#whale-nerdctl-pull

I think with our current setup we might have to change imagePullCmd to something like this to have retries -

imagePullCmd = []string{"sh", "-c", `
for i in 1 2 3; do
  nerdctl pull -q --snapshotter soci "$@" && exit 0
  sleep 5
done
exit 1
`, "--"}

and the usage remains the same as-is - sh.X(append(imagePullCmd, "--soci-index-digest", indexDigest, imgInfo.ref)...)

For now I would just change the PR to only have Image change and --user flag removal 😄

[prafgup]

@Shubhranshu153 flaky test failure again in one of the the checks due to networking, can you please re-run that?

[Swapnanil-Gupta]

Thanks! LGTM.