Add minimal crictl integration test + setup#1952
Conversation
|
@sondavidb ping regarding - #1943 (comment) |
|
Seems like containerd 2.x integration tests are failing as we are not using the Lemme quickly fix it! |
Signed-off-by: Praful Gupta <prafulgupta6@gmail.com>
07f7d54 to
1387c02
Compare
|
Ran with both after this addition - https://github.com/awslabs/soci-snapshotter/compare/07f7d54d55101c04799ef63e7ff64a13805d326e..1387c027af5960c17180b177ac542f0a7c769bf7 1.7.x - 2.x - @sondavidb can you rerun the jobs 🙏 |
|
Apologies to ping directly @Swapnanil-Gupta @sondavidb , I was wondering if there are any plans of releases soon so we can evaluate next steps on our end and not be blocked on it? We needed these - |
|
Hey @prafgup , not sure about how soon but we can look to. I'd like to see if we can get concatenated image support added before then. Just been busy with other work stuff apologies. |
sondavidb
left a comment
There was a problem hiding this comment.
Thanks for this! This is definitely good enough as a sanity check for now.
I have a lot of ideas that I need to think through for adding crictl. My initial thoughts were to test every applicable command with both nerdctl + crictl, but I think this will make our CI take over an hour which is not ideal.
I think we can probably have the matrix run a separate set of runners for nerdctl + crictl and just try to set it up differently based on which environment. But that might be a ways out. 100% out of scope here.
Thanks!
Issue #, if available:
Helps with initializing the infra and basic test for - #1572
Description of changes:
Initializing the testing setup for crictl to get more closer to mimicking the behavior of k8s, in future we can choose to refactor/extend this as we require. This PR is just a initial setup with a basic passing test verifying the remote snapshot creation.
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.