Add checks before generating a release#2019
Open
sondavidb wants to merge 1 commit into
Open
Conversation
Ideally we would want to run checks before pushing a tag, however the infra required for the GPG key does not currently exist and would require a revamp of our existing architecture. So this is the stop-gap solution I've arrived at, which will let maintainers push a tag but not allow the release to be created if the requisite checks don't pass. This isn't an amazing solution but having a dead tag floating around for a couple of minutes is definitely better than missing release artifacts. Signed-off-by: David Son <davbson@amazon.com>
github-actions
Bot
added
the
github_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ideally we would want to run checks before pushing a tag, however the infra required for the GPG key does not currently exist and would require a revamp of our existing architecture. So this is the stop-gap solution I've arrived at, which will let maintainers push a tag but not allow the release to be created if the requisite checks don't pass.
This isn't an amazing solution but having a dead tag floating around for a couple of minutes is definitely better than missing release artifacts.
Testing performed:
Workflow run with correct artifacts in place: https://github.com/sondavidb/soci-snapshotter/actions/runs/27792753716
Workflow cut off main (missing THIRD_PARTY_LICENSES): https://github.com/sondavidb/soci-snapshotter/actions/runs/27792753716
Workflow run with correct assets in place but bad THIRD_PARTY_LICENSES: https://github.com/sondavidb/soci-snapshotter/actions/runs/27793042063
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.