not all envars must be secrets #232
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Allow plaintext values for selected environment variables
Update the
configLambda()
function to support non-secret (plaintext) values for selected environment variables. Previously, variables likeGOOGLE_ADMIN
,GOOGLE_CREDENTIALS
,REGION
, andIDENTITY_STORE_ID
were always assumed to reference AWS Secrets Manager ARNs.With this change:
If the environment variable starts with
arn:aws:secretsmanager:
, the existing secrets manager lookup is used.Otherwise, the value is used as-is, enabling easier local development and simpler deployments that don’t require Secrets Manager.
Introduced
maybeSecret()
helper to conditionally unwrap secrets.Applied it to
GOOGLE_ADMIN
,GOOGLE_CREDENTIALS
,SCIM_ENDPOINT
,REGION
, andIDENTITY_STORE_ID
.Previously:
Now allowed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.