fix bug with tags endpoints not working

awslabs · Nov 19, 2024 · 0c8a1a8 · 0c8a1a8
1 parent 662635d
commit 0c8a1a8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/api/utils.py b/api/utils.py
@@ -231,7 +231,7 @@ def generate_presigned_url(
 @tracer.capture_method(capture_response=False)
 def get_clean_item(obj: any) -> dict:
     """Converts a Pydantic model to 'clean' dict (no null or empty properties)"""
-    obj_dict = json.loads(obj.json())
+    obj_dict = json.loads(obj.model_dump_json())
     remove_null(obj_dict)
     return obj_dict
 

diff --git a/functions/api_flows/app.py b/functions/api_flows/app.py
@@ -23,7 +23,7 @@
 from aws_lambda_powertools.utilities.typing import LambdaContext
 from boto3.dynamodb.conditions import Key
 from mediatimestamp.immutable import TimeRange
-from schema import Deletionrequest, Flow, Flowstorage, Flowstoragepost, Source
+from schema import Deletionrequest, Flow, Flowstorage, Flowstoragepost, Source, Tags
 from utils import (
     base_delete_request_dict,
     check_delete_source,
@@ -347,7 +347,7 @@ def put_flow_tag_value(flowId: str, name: str):
     if not isinstance(body, str):
         raise BadRequestError("Bad request. Invalid flow tag value.")  # 400
     if flow.root.tags is None:
-        flow.root.tags = {name: body}
+        flow.root.tags = Tags(root={name: body})
     else:
         flow.root.tags.root[name] = body
     now = datetime.now().strftime(constants.DATETIME_FORMAT)

diff --git a/functions/api_sources/app.py b/functions/api_sources/app.py
@@ -20,7 +20,7 @@
 from aws_lambda_powertools.utilities.parser import parse
 from aws_lambda_powertools.utilities.typing import LambdaContext
 from boto3.dynamodb.conditions import Key
-from schema import Source
+from schema import Source, Tags
 from utils import (
     generate_link_url,
     get_clean_item,
@@ -164,7 +164,7 @@ def put_source_tag_value(sourceId: str, name: str):
         raise BadRequestError("Bad request. Invalid Source tag value.")  # 400
     source: Source = parse(event=item["Item"], model=Source)
     if source.tags is None:
-        source.tags = {name: body}
+        source.tags = Tags(root={name: body})
     else:
         source.tags.root[name] = body
     now = datetime.now().strftime(constants.DATETIME_FORMAT)