SQS: Add autoconfiguration for maxDelayBetweenPolls #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added configuration property to SqsProperties - Added mapping for SqsContainerOptions.maxDelayBetweenPolls in SqsAutoConfiguration for configuring properties in SqsMessageListenerContainerFactory - Included the test for new property in SqsAutoConfigurationTest - Added docs for the new property max-delay-between-polls Closes awspring#1354
krutip7
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: sqs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR includes following changes:
maxDelayBetweenPollsconfiguration property toSqsPropertiesSqsContainerOptions.maxDelayBetweenPollsinSqsAutoConfigurationfor configuring the property inSqsMessageListenerContainerFactorySqsAutoConfigurationTestspring.cloud.aws.sqs.listener.max-delay-between-polls💡 Motivation and Context
Currently, there is no property available to configure the
maxDelayBetweenPollsparameter for SQS Listener, making it difficult to configure it through the application properties. This change introduces the propertymax-delay-between-pollsfor SQS Listener.Closes #1354
💚 How did you test it?
Built the project after making necessary changes and included the generated jar in a sample application. Ran this application in debug mode to verify whether the value mentioned in
application.propertiesformax-delay-between-pollswas being picked and correctly configured inSqsContainerOptionsfor the defaultSqsListenerContainerFactorybean.📝 Checklist
🔮 Next steps