[pull] main from grimme-lab:main - #52
Merged
Merged
Conversation
I noticed that there is an incompatibility in the toml-f version defined here in mctc-lib (toml-f v0.4.2) and in the jonquil (toml-f head) dependency. This leads to the v0.4.2 released version of toml-f being used, which brings back already solved issues on MacOS (particularly [tomlf/#152](toml-f/toml-f#152)). There are a few examples when testing [multicharge](https://github.com/grimme-lab/multicharge/actions/runs/17825142478/job/50676491358), [xtb with all test](https://github.com/thfroitzheim/xtb/actions/runs/19199479482/job/54885239568) and [simple-dftd3](https://github.com/thfroitzheim/simple-dftd3/actions/runs/19208308381/job/54906760205) (the latter has the same problem of overwriting the jonquil toml-f version). Before we set here the toml-f dependency always to `head`, I think a new toml-f and jonquil release with fixed versions would be more helpful (see [toml-f/162](toml-f/toml-f#162), therefore I made this only a draft). --------- Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com>
Same as in #102 but also for fpm and cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )