WIP: Directional tiles#1
Open
honzaflash wants to merge 7 commits into
Open
Conversation
- move the mesh generation and shading from `render` body to their own methods and refactor small things
- also use autoscale when `colorscalerrange` is `None` for type checker's sake even though
validation ensures this happens only when `autoscale` is `True`
- fix an overly narrow type hint (caused type error elsewhere)
- move styles related query parameter processing to its own function too and refactor a little
- update the GetMap query model in a backwards compatible way to support more ncWMS-like parameters - `styles` will be used to set colormap/arrows/... - `palette` will be used to specify colormap name - but colormap name in `styles` is still supported - get_map.py was getting long so move it into a dir module - add an "arrows" style for visualizing vector direction - implement the directional arrows rendering option
- use cos/sin instead of the inverse to get the coordinate from the angle
- fix: - typo in string literal - wrong mesh type hint - mesh indexing and rendering scale - inverted Y axis - also rename/refactor a little more
- make color and density configurable by user - store output style options nested in an object instead of flat as attributes of GetMap - this way the class isn't polluted by attributes not relevant to the used rendering style - type checker can infer stuff based on the discriminator field (`styles.type`)
- test query parameter parsing for the arrows and colormap style options
- drop scale parameter as it is redundant after the mesh is projected (bbox and pixel dimensions are given by user, glyph density can still be configured by user) - generalize tile size handling for rectangles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We want to support server-side rendering of directional arrow overlay tiles. These could be overlayed with magnitude tiles by the client.
xpublish-community#146