Refactor InputSystem by halx99 · Pull Request #3173 · axmolengine/axmol

halx99 · 2026-05-19T03:34:48Z

Describe your changes

Replace legacy TextFieldTTF usage/removal and shift text input flows toward ui::InputField/IME-based behavior.
Add unified Label::create(text, fontName, fontSize) API with automatic font-type detection (BMFont/TTF/system font).
Add Label::setFontInfo(fontName, fontSize) to centralize runtime font switching.
Clean up Label internals by removing cached _lengthOfString state and deriving count from UTF-32 text (getCharCount()), reducing stale-length risks.
Introduce/rename clearer label query APIs (getLineCount(), getCharCount()) while keeping backward-compatible deprecated wrappers.
Harden UTF-8 handling paths in label/text operations (avoid accepting invalid UTF-8 silently).
Update desktop/input related plumbing and scene/UI compatibility touchpoints associated with the migration.
Apply broad cleanup/modernization in tests and headers (e.g., #pragma once, include path corrections, minor code hygiene).
Integrate iOS System Copy/Paste Menu for InputField Editing

Issue ticket number and link

Checklist before requesting a review

For each PR

Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.

Optional:
- I have checked readme and add important infos to this PR.
- I have added/adapted some tests too.

For core/new feature PR

I have checked readme and add important infos to this PR.
I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

Check the '#include "axmol.h"' and replace it with the needed headers.

halx99 · 2026-05-19T03:36:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 211c215351

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-20T03:28:59Z

/clang-format

halx99 · 2026-05-20T03:49:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2aff1905b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-20T07:53:18Z

/clang-format

halx99 · 2026-05-21T15:23:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa51937953

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-22T12:12:01Z

/clang-format

halx99 · 2026-05-22T16:11:03Z

@codex review

halx99 · 2026-05-22T16:11:32Z

/clang-format

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca81b1bcfa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-22T16:32:32Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f219568f06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-22T17:00:15Z

@codex review

halx99 · 2026-05-22T17:02:08Z

@codex About this PR, do you have any suggestion to improve ui::InputField implementation?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00d565bf4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-23T07:37:26Z

/clang-format

halx99 · 2026-05-23T09:12:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ac07dc212c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

halx99 · 2026-05-23T16:14:53Z

/clang-format

halx99 · 2026-05-24T03:11:43Z

@codex review

halx99 · 2026-05-24T03:14:19Z

@codex provide merge title and change detail list about this PR via https://patch-diff.githubusercontent.com/raw/axmolengine/axmol/pull/3173.diff

halx99 · 2026-05-24T03:15:00Z

/clang-format

chatgpt-codex-connector · 2026-05-24T03:15:10Z

Proposed merge metadata based on the PR diff and review context:

Merge title

Refactor legacy text input stack to ui::InputField and unify font handling APIs

Change detail list (for squash/merge message)

Replace legacy TextFieldTTF usage/removal and shift text input flows toward ui::InputField/IME-based behavior.
Add unified Label::create(text, fontName, fontSize) API with automatic font-type detection (BMFont/TTF/system font).
Add Label::setFontInfo(fontName, fontSize) to centralize runtime font switching.
Clean up Label internals by removing cached _lengthOfString state and deriving count from UTF-32 text (getCharCount()), reducing stale-length risks.
Introduce/rename clearer label query APIs (getLineCount(), getCharCount()) while keeping backward-compatible deprecated wrappers.
Harden UTF-8 handling paths in label/text operations (avoid accepting invalid UTF-8 silently).
Update desktop/input related plumbing and scene/UI compatibility touchpoints associated with the migration.
Apply broad cleanup/modernization in tests and headers (e.g., #pragma once, include path corrections, minor code hygiene).

If you want, I can also draft a “merge title + detailed changelog” in Conventional Commits style (e.g., refactor(ui): ...) for direct paste into GitHub.

Source used:

Diff: https://patch-diff.githubusercontent.com/raw/axmolengine/axmol/pull/3173.diff

View task →

gemini-code-assist

Code Review

This pull request refactors the UI and text input systems, replacing legacy TextField components with a new InputField widget and introducing a cross-platform clipboard API. It also updates the layout system by replacing ignoreContentAdaptWithSize with setAutoSize and renames various UI headers for consistency. Feedback highlights critical logic inversions in the setAutoSize implementation for several widgets (Button, ImageView, Slider, and LoadingBar) when Scale9 is enabled, which hinders manual sizing. Further improvements are suggested for Android clipboard robustness, touch position tracking in InputField, and optimizing the O(N^2) performance of the text layout measurement logic.

gemini-code-assist · 2026-05-24T09:38:14Z

Hello halx99, thank you for reaching out. Regarding your question about the ui::InputField implementation, it is designed to be a more modern, IME-friendly replacement for the legacy TextFieldTTF.

Key improvements include:

IME Integration: It utilizes the new InputDelegate and InputDispatcher architecture, which provides better support for platform-native IME features (like pre-edit text updates) compared to the legacy IMEDelegate.
Cursor & Selection: It includes built-in cursor management and selection handling, which were significant pain points in the legacy implementation.
Font Flexibility: The unified Label::create(text, fontName, fontSize) API allows for easier font handling across different types (BMFont, TTF, System).
Performance: By deriving character counts from UTF-32 text (getCharCount()) and removing stale state like _lengthOfString, it reduces synchronization risks and improves performance.

If you are looking to migrate from TextFieldTTF or TextField, I recommend focusing on the InputField factory methods and the event-based listener system (addEventListener) to handle input changes, as this is the intended pattern for the new stack. Let me know if you have specific architectural questions or need help with a particular use case!

halx99 · 2026-05-24T10:21:21Z

@gemini review

gemini-code-assist

Code Review

This pull request performs a major refactoring of the UI and input systems, replacing the deprecated TextFieldTTF and TextFieldEx widgets with a new InputField component that supports multiline text, cursors, and selections. The refactor includes a widespread renaming of UI classes and core methods (e.g., setAutoSize, getRenderNode) to improve API consistency, renames the IME system to a more general Input system, and introduces a cross-platform clipboard API. Review feedback identifies a high-severity risk of null pointer exceptions in the Android clipboard implementation and suggests adopting safer string access patterns in the InputField logic.

halx99 · 2026-05-24T10:31:41Z

/clang-format

halx99 · 2026-05-24T12:50:11Z

/clang-format

halx99 · 2026-05-24T13:00:34Z

/gemini review

gemini-code-assist

Code Review

This pull request overhauls the text input and UI widget systems by introducing a modern InputField component to replace the deprecated TextFieldTTF and TextFieldEx. The new InputField supports multiline text, cursor control, selection, and native clipboard integration. Additionally, the Widget base class and its derivatives have been refactored to use a standardized setAutoSize and initRenderNode API, and the IME system has been renamed to InputDelegate. Reviewer feedback highlights significant efficiency and correctness concerns regarding character-by-character text measurement and the lack of word-level wrapping in multiline mode. Other actionable suggestions include syncing measurement labels with rendering effects, adjusting long-press trigger timing on mobile platforms, and correcting a typo in Label.cpp.

codacy-production · 2026-06-04T10:45:51Z

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results

ErrorProne 1 high

View in Codacy

🟢 Metrics 4329 complexity · 98 duplication

Metric Results

Complexity 4329

Duplication 98

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

halx99 · 2026-06-07T10:33:54Z

/clang-format

halx99 added this to the 3.0.0 milestone May 19, 2026

halx99 linked an issue May 19, 2026 that may be closed by this pull request

Refactor InputSystem #3168

Open

halx99 changed the title ~~Input field~~ Implement #3168 May 19, 2026

chatgpt-codex-connector Bot reviewed May 19, 2026

View reviewed changes

Comment thread axmol/ui/UIWidget.cpp Outdated

Comment thread extensions/scripting/lua-bindings/auto/axlua_ui_auto.cpp Outdated

chatgpt-codex-connector Bot reviewed May 20, 2026

View reviewed changes

Comment thread extensions/sceneio/src/sceneio/WidgetReader/WidgetReader.cpp Outdated

Comment thread axmol/ui/UIButton.cpp Outdated

Comment thread axmol/ui/UIWidget.cpp Outdated

Comment thread axmol/ui/InputField.cpp Outdated

chatgpt-codex-connector Bot reviewed May 21, 2026

View reviewed changes

Comment thread axmol/ui/InputField.cpp Outdated

Comment thread axmol/ui/InputField.cpp Outdated

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread axmol/ui/InputField.cpp Outdated

Comment thread axmol/base/text_utils.cpp Outdated

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread axmol/platform/desktop/RenderViewImpl.cpp Outdated

Comment thread axmol/platform/pc/RenderView-pc.cpp

halx99 force-pushed the input-field branch from 5e556bf to a950fb8 Compare May 22, 2026 16:56

halx99 added the enhancement New feature or request label May 22, 2026

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread extensions/sceneio/src/sceneio/ActionTimeline/CSLoader.cpp Outdated

Comment thread axmol/base/IMEDispatcher.cpp Outdated

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Comment thread axmol/platform/desktop/Device-desktop.cpp Outdated

Comment thread axmol/platform/desktop/Device-desktop.cpp Outdated

Comment thread axmol/platform/desktop/Device-desktop.cpp Outdated

axmolengine deleted a comment from chatgpt-codex-connector Bot May 24, 2026

gemini-code-assist Bot reviewed May 24, 2026

View reviewed changes

Comment thread axmol/platform/android/java/src/dev/axmol/lib/AxmolEngine.java

Comment thread axmol/ui/InputField.cpp Outdated

gemini-code-assist Bot reviewed May 24, 2026

View reviewed changes

Comment thread axmol/ui/InputField.cpp

Comment thread axmol/2d/Label.cpp

Comment thread axmol/ui/InputField.cpp

Comment thread axmol/ui/InputField.cpp

Comment thread axmol/ui/InputField.cpp

Comment thread axmol/ui/InputField.cpp

halx99 marked this pull request as draft May 25, 2026 23:45

halx99 added the breaking changes label May 27, 2026

halx99 changed the title ~~Refactor legacy text input stack to ui::InputField and unify font handling APIs~~ Refactor InputSystem Jun 2, 2026

halx99 linked an issue Jun 3, 2026 that may be closed by this pull request

ImGui text and numeric input widgets do not accept keyboard input on macOS after updating to v1.92.7 #3185

Open

halx99 force-pushed the input-field branch 3 times, most recently from d163ad8 to 4e27179 Compare June 7, 2026 09:05

Squash commits

a99a0d2

halx99 force-pushed the input-field branch from 4e27179 to a99a0d2 Compare June 7, 2026 09:57

halx99 added 2 commits June 7, 2026 18:16

Fix luabindings

4a175bf

Fix lua bindings

8c95c34

axmol-bot and others added 7 commits June 7, 2026 10:36

Committing clang-format changes

5c5dc54

Fixup

4b5e188

Refactor name

4e7fa22

Add event & event listener alias

b89ac55

Add event alias and fix template

5061ef4

up

7df695c

Update menu

321e3cd

Uh oh!

Conversation

halx99 commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

For core/new feature PR

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

Uh oh!

halx99 commented May 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 20, 2026

Uh oh!

halx99 commented May 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 20, 2026

Uh oh!

halx99 commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 22, 2026

Uh oh!

halx99 commented May 22, 2026

Uh oh!

halx99 commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 22, 2026

Uh oh!

halx99 commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

halx99 commented May 23, 2026

Uh oh!

halx99 commented May 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

halx99 commented May 19, 2026 •

edited

Loading

codacy-production Bot commented Jun 4, 2026 •

edited

Loading