Add a dist_url_override config key
#1509
Conversation
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
5 times, most recently
from
d97bb5e to
adb1292
Compare
fasterthanlime
changed the base branch from
main
to
strict-undefined-behavior
fasterthanlime
force-pushed
the
strict-undefined-behavior
branch
from
0c6a265 to
eb4e8ee
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
3 times, most recently
from
4bd1af1 to
6dc0fec
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
2 times, most recently
from
72f0eed to
dbef951
Compare
fasterthanlime
force-pushed
the
strict-undefined-behavior
branch
from
c53a91e to
3449d7f
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
8b8d391 to
86341d0
Compare
fasterthanlime
force-pushed
the
strict-undefined-behavior
branch
6 times, most recently
from
6b54bd3 to
4c88c10
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
86341d0 to
f4a4726
Compare
fasterthanlime
changed the base branch from
main
to
use-checksum-in-installers
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
f4a4726 to
b7c87e9
Compare
fasterthanlime
force-pushed
the
use-checksum-in-installers
branch
from
06c6ee4 to
05c6466
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
3 times, most recently
from
06afd24 to
b09e9a7
Compare
fasterthanlime
force-pushed
the
use-checksum-in-installers
branch
from
05c6466 to
34ce732
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
b09e9a7 to
4a7df3a
Compare
fasterthanlime
changed the title
cargo_dist_url_override keydist_url_override config key
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
3 times, most recently
from
f44f975 to
8f9afc5
Compare
mistydemeo
left a comment
mistydemeo
left a comment
There was a problem hiding this comment.
Looking good. This'll be handy for testing, and may end up being useful for other people too.
| "mach_object", | ||
| "miette 7.2.0", | ||
| "newline-converter", | ||
| "schemars", |
There was a problem hiding this comment.
Unrelated to anything else but I'm fascinated by this surprise Cargo.lock change.
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
8f9afc5 to
378f1c2
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
378f1c2 to
6b00dad
Compare
fasterthanlime
force-pushed
the
cargo-dist-url-override
branch
from
6b00dad to
f8e0688
Compare
|
Note that the config key is named |
mistydemeo
left a comment
mistydemeo
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround on that fix. Just running a test now. https://github.com/mistydemeo/cargodisttest/actions/runs/11711074752
| submodules: recursive | ||
| - name: Install dist | ||
| run: ${{ matrix.install_dist }} | ||
| shell: ${{ matrix.install_dist.shell }} |
There was a problem hiding this comment.
We probably have to regenerate our own release YAML now.
I'm also running a test using the |
That test was successful and the tests are green. Merging! |
...for quick iteration on cargo-dist itself.
The rationale is explained in the code comments itself.
I have tested this on Linux, via https://github.com/fasterthanlime/bye/releases/tag/v0.6.0 — I have not tested the powershell version yet, lemme do that before taking this PR out of draft.