Skip to content

Conversation

@AThePeanut4
Copy link
Contributor

This is a simple fix for astral-sh/uv#12942, where if you run the installer as root the resulting binaries end up with weird UID/GID values.

When running as root, tar uses --same-owner by default, which causes the issue. So just specifying --no-same-owner (the default for non-root users) fixes the problem.

@mistydemeo
Copy link
Contributor

Good catch, thank you!

The test fixtures will need updating; would you like me to do that for you?

@AThePeanut4
Copy link
Contributor Author

@mistydemeo Er I don't really know where I need to be changing things, so yes that would be much appreciated :)

Also I just did a search for --strip-components in github and I see there's a binary-install.js and installer.ps1 - I'm not sure if this change needs to be made there as well.

@mistydemeo
Copy link
Contributor

installer.ps1 runs on Windows and I don't think Windows handles user permissions the same way. We should check if the CLI flag exists on Windows tar. As for binary.js... that's the npm installer. That one should be possible to run as root, so we might also need it there.

@mistydemeo mistydemeo merged commit e9bf6ab into axodotdev:main Dec 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants