-
Notifications
You must be signed in to change notification settings - Fork 123
fix: typo in variable name #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oops, thanks! |
4343e8b to
012a268
Compare
|
UPDATE: I got the test to pass via installing specifically version 0.7.0 of Running the github action on my fork passes all checks https://github.com/20jasper/cargo-dist/actions/runs/20531652494/job/58983776926?pr=2 ORIGINAL: For transparency, I just pushed a manual update to the snapshot for the failing Any tips on how to get this test working? I get "command not found" when running all tests on running dist build -aglobal...
Error: × "cargo-dist dist build -aglobal" failed (exit status: 255)
╰─▶
stdout:
stderr:
× The following tools are required to run this task, but are missing:
│ - omnibor-cli
help: Please install the tools mentioned above and try again.After installing running dist build -aglobal...
Error: × "cargo-dist dist build -aglobal" failed (exit status: 255)
╰─▶
stdout:
stderr:
building artifacts:
source.tar.gz
source.tar.gz.sha256
source.tar.gz.omnibor
axolotlsay-installer.sh
axolotlsay-installer.ps1
axolotlsay.rb
axolotlsay-npm-package.tar.gz
axolotlsay.cdx.xml
sha256.sum
× failed to generate an OmniBOR Artifact ID (status: exit status: 2) |
|
Oh! That's why some people have been having trouble running that test! Right, that one is testing calling the |
Thank you! |
Made a draft PR and included some doubts I had! #2234 |
mistydemeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes a typo in the
builderGlibcMInorVersion. TheIin MInor shouldn't be capitalized