logsource: delay source wakeup#1096
Open
bazsi wants to merge 1 commit into
Open
Conversation
MrAnno
reviewed
May 28, 2026
bazsi
force-pushed
the
logsource-delay-wakeup-to-improve-batching
branch
3 times, most recently
from
160f88c to
a46731d
Compare
Do not wakeup the source immediately once the first slot in the window becomes available, rather wait roughly a batch, so the source can iterate on multiple messages, instead of just one. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
bazsi
force-pushed
the
logsource-delay-wakeup-to-improve-batching
branch
from
a46731d to
4c5c4fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another batching improvement to increase the source-side batches. Instead of waking up the source immediately after a single message becomes available, wait up to 100 messages to be drained from the window and then wakup the source.
This removes the pressure on iv_event_post() in the ivykis mainloop, as well as generating larger batches in LogScheduler, reducing log contention and latency.