Debugger filterx#356
Draft
bazsi wants to merge 7 commits into
Draft
Conversation
bazsi
force-pushed
the
debugger-filterx
branch
from
99c2015 to
225043f
Compare
bazsi
force-pushed
the
debugger-filterx
branch
3 times, most recently
from
f4d3ba1 to
bcd453e
Compare
bazsi
force-pushed
the
debugger-filterx
branch
3 times, most recently
from
de500f3 to
2439191
Compare
Closed
bazsi
force-pushed
the
debugger-filterx
branch
2 times, most recently
from
aa1f9c6 to
72b0fc5
Compare
This is not a fastpath, so we can use atomics and the debugger needs to ref/unref expressions in the debugger thread, which causes failed assertions. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Instead of returning a fully formed compound expression, just return the list of expressions, so the brace is processed by the parent grammar. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Exclude other threads simply by only allowing these calls to be made while parsing is in progress, which is inherently single-threaded. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
So that changes in previous filterx blocks take effect in the message by the time we get to the debugger. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the printx/px commands to the debugger which evaluates a filterx expression.
This should go in after #546, #547 and #340