-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add deviceid for host attribution #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
42e12d9 to
14f556b
Compare
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
14f556b to
a2344e8
Compare
OverOrion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem you experienced is (mostly) solved with open-telemetry/opentelemetry-collector#12097
One we do a version upgrade we can opt into this if we want to. (Not applicable for processors though, that's why I said mostly.)
The bottom line is that we can keep common-config.yaml and all the specific yamls can specify their own whole logs pipeline for now:
receivers: [azureeventhub]
processors: [resource/axoflow, resourcedetection/system,, resource/axoflow_device_id]
exporters: [otlp/axorouter]The root cause is that list merging is not supported as of now, and it gets overwritten. However we can still leverage yaml merging capability by only duplication the logs pipeline part.
What do you think?
I believe that if this issue was present before, and now it would only be available under a feature-gate, I would go with not using a common-config, because I would like to avoid problems like these in the future. Also there is not that much we gain from a common-config, if you check the individual configs in this PR, I marked provider-specific configs with a comment, and that is not too much, we needed to add. In other words this does not pose a huge "maintain-burden" on us IMHO. |
Signed-off-by: Bence Csati <[email protected]>
a2344e8 to
bdeaaff
Compare
No description provided.