Skip to content

Conversation

@csatib02
Copy link
Member

No description provided.

@csatib02 csatib02 requested a review from pepov June 11, 2025 14:09
@csatib02 csatib02 self-assigned this Jun 11, 2025
@csatib02 csatib02 added the enhancement New feature or request label Jun 11, 2025
@csatib02 csatib02 force-pushed the feat/host-attribution branch from 42e12d9 to 14f556b Compare June 12, 2025 10:55
@csatib02 csatib02 force-pushed the feat/host-attribution branch from 14f556b to a2344e8 Compare June 19, 2025 08:02
@csatib02 csatib02 requested a review from OverOrion June 19, 2025 08:04
@pepov pepov requested a review from tarokkk June 19, 2025 08:09
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem you experienced is (mostly) solved with open-telemetry/opentelemetry-collector#12097

One we do a version upgrade we can opt into this if we want to. (Not applicable for processors though, that's why I said mostly.)


The bottom line is that we can keep common-config.yaml and all the specific yamls can specify their own whole logs pipeline for now:

      receivers: [azureeventhub]
      processors: [resource/axoflow, resourcedetection/system,, resource/axoflow_device_id]
      exporters: [otlp/axorouter]

The root cause is that list merging is not supported as of now, and it gets overwritten. However we can still leverage yaml merging capability by only duplication the logs pipeline part.

What do you think?

@csatib02
Copy link
Member Author

The problem you experienced is (mostly) solved with open-telemetry/opentelemetry-collector#12097

One we do a version upgrade we can opt into this if we want to. (Not applicable for processors though, that's why I said mostly.)

The bottom line is that we can keep common-config.yaml and all the specific yamls can specify their own whole logs pipeline for now:

      receivers: [azureeventhub]
      processors: [resource/axoflow, resourcedetection/system,, resource/axoflow_device_id]
      exporters: [otlp/axorouter]

The root cause is that list merging is not supported as of now, and it gets overwritten. However we can still leverage yaml merging capability by only duplication the logs pipeline part.

What do you think?

I believe that if this issue was present before, and now it would only be available under a feature-gate, I would go with not using a common-config, because I would like to avoid problems like these in the future. Also there is not that much we gain from a common-config, if you check the individual configs in this PR, I marked provider-specific configs with a comment, and that is not too much, we needed to add. In other words this does not pose a huge "maintain-burden" on us IMHO.

@csatib02 csatib02 requested a review from OverOrion June 23, 2025 11:14
@csatib02 csatib02 force-pushed the feat/host-attribution branch from a2344e8 to bdeaaff Compare July 15, 2025 07:24
@csatib02 csatib02 merged commit d637ccd into main Jul 15, 2025
2 checks passed
@csatib02 csatib02 deleted the feat/host-attribution branch July 15, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants