Skip to content

Add communication dtypes for all-gathers and reduce scatters in depth tensor parallelism #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Add communication dtypes for all-gathers and reduce scatters in depth tensor parallelism #64

wants to merge 3 commits into from

Conversation

@siddharth9820
Copy link
Collaborator

@siddharth9820 siddharth9820 commented Feb 26, 2024

Why?

  1. Reduce scatters - happen on weight gradients, and researchers increasingly want to do these in fp32.
  2. All gathers - with torch.autocast, these were happening in fp32 by default. We can afford to do these in bf16/fp16.

@siddharth9820 siddharth9820 marked this pull request as draft February 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prajwal1210 prajwal1210 Awaiting requested review from prajwal1210

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharth9820