Add SSL host verification and insecure skip verify CLI flags - #77
Merged
Conversation
digiserg
force-pushed
the
feat/ssl-validation
branch
from
April 10, 2026 08:07
6333549 to
12135eb
Compare
…flags Expose the SSL hostVerification and insecureSkipVerify config options via CLI flags and environment variables (CQLAI_NO_SSL_HOST_VERIFICATION, CQLAI_NO_SSL_INSECURE_SKIP_VERIFY). CLI flags take precedence over env vars, which take precedence over the config file.
digiserg
force-pushed
the
feat/ssl-validation
branch
from
April 10, 2026 08:10
12135eb to
98226a8
Compare
digiserg
changed the title
…verify flags Godog feature file and step definitions covering: flag overrides config, env var applies when flag is unset, CLI flag takes precedence over env var, and nil-pointer semantics when neither is set.
Python's cqlsh writes True/False with capital letters. Our comparisons were case-sensitive so 'ssl = True' never enabled SSL from [connection], and 'validate = False' fell into the else branch and incorrectly set HostVerification=true instead of InsecureSkipVerify=true. Fix by using strings.ToLower before comparing boolean values in loadCQLSHRC.
rgooding
approved these changes
Apr 10, 2026
hshimizu
pushed a commit
that referenced
this pull request
May 14, 2026
* Add --no-ssl-host-verification and --no-ssl-insecure-skip-verify CLI flags Expose the SSL hostVerification and insecureSkipVerify config options via CLI flags and environment variables (CQLAI_NO_SSL_HOST_VERIFICATION, CQLAI_NO_SSL_INSECURE_SKIP_VERIFY). CLI flags take precedence over env vars, which take precedence over the config file. * Add BDD tests for --no-ssl-host-verification and --ssl-insecure-skip-verify flags Godog feature file and step definitions covering: flag overrides config, env var applies when flag is unset, CLI flag takes precedence over env var, and nil-pointer semantics when neither is set. * Fix cqlshrc SSL boolean values not being parsed case-insensitively Python's cqlsh writes True/False with capital letters. Our comparisons were case-sensitive so 'ssl = True' never enabled SSL from [connection], and 'validate = False' fell into the else branch and incorrectly set HostVerification=true instead of InsecureSkipVerify=true. Fix by using strings.ToLower before comparing boolean values in loadCQLSHRC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan