Skip to content

Backup operation for single volume should not be accepted for running instance. #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Metallion wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Backup operation for single volume should not be accepted for running instance. #622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1399f4
/volumes/vol-xxxx/backup should only be performed for halted instance.
Apr 1, 2015
fd22b69
Merge branch 'develop' into fix-reject-running-instance-backup
Jun 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dcmgr/lib/dcmgr/endpoints/12.03/volumes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,12 @@
raise E::UnknownVolume, params[:id] if @volume.nil?
raise E::InvalidVolumeState, params[:id] unless @volume.ready_to_take_snapshot?

if @volume.instance && !['running', 'halted'].member?(@volume.instance.state.to_s)
raise E::InvalidInstanceState, @volume.instance.canonical_uuid
if @volume.instance
# TODO: look into host node capability if the node supports
# snapshot backup.
if ![C::Instance::STATE_HALTED].member?(@volume.instance.state.to_s)
raise E::InvalidInstanceState, @volume.instance.canonical_uuid
end
end

bkst = find_target_backup_storage(@volume.service_type)
Expand Down