fix(examples): return XDP_PASS for non-TCP/UDP packets in xdp-log - #277
Open
rootacite wants to merge 1 commit into
Open
fix(examples): return XDP_PASS for non-TCP/UDP packets in xdp-log#277rootacite wants to merge 1 commit into
rootacite wants to merge 1 commit into
Conversation
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi maintainers! Thanks for the awesome work on Aya.
While testing the
xdp-logexample, I noticed a slightly unexpected behavior. Currently, non-TCP/UDP IPv4 traffic (like ICMP) hits the_ => return Err(())arm intry_xdp_firewall. This propagates to the outer function and returnsxdp_action::XDP_ABORTED.When the example is loaded, the host cannot be pinged (ICMP requests are unexpectedly dropped), and the kernel frequently triggers
xdp_exceptiontracepoints for normal ICMP packets.I'm wondering if this was an intentional design choice for demonstration purposes?
If it's a minor oversight, this PR changes it to early-return
Ok(xdp_action::XDP_PASS). I've tested this locally: ICMP traffic recovers perfectly.Thanks!
This change is