Add codegen command to generate BTF bindings for kprobetcp - #83
Open
clnv wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vadorovsky
requested changes
Jan 23, 2023
vadorovsky
left a comment
vadorovsky
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
The code looks good, but I think we should include the info about cargo xtask codegen command also in the doc (docs/book/programs/probes.md), like here:
https://aya-rs.dev/book/programs/cgroup-skb/#generating-bindings-to-vmlinuxh
Member
|
@zarvd do you plan to address the comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
cargo +nightly xtask codegento generatekrpobetcp-ebpf/src/bindings.rs.This change is