fix(tests): resolve macOS /var symlink in OpenCode plugin test - #190
Open
Franky100-pig wants to merge 1 commit into
Open
fix(tests): resolve macOS /var symlink in OpenCode plugin test#190Franky100-pig wants to merge 1 commit into
Franky100-pig wants to merge 1 commit into
Conversation
On macOS /var is a symlink to /private/var. setUp built self.plugin_root from tempfile's un-resolved path (/var/...), while the Node plugin resolves its own location to /private/var/... via import.meta.url, so the skill-path assertions compared mismatched strings and 5 OpenCodePluginTest cases failed on macOS. Linux CI stayed green because /var is not a symlink there, hiding the bug. Resolve the temp root with os.path.realpath in setUp so both sides use the same canonical path. No behavior change to the skill or plugin; on Linux realpath is a no-op, so CI is unaffected. Verification: python3 -m unittest discover -s tests — before: 5 failures (OpenCodePluginTest skill-path assertions); after: Ran 51 tests ... OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS /var is a symlink to /private/var. setUp built self.plugin_root from tempfile's un-resolved path (/var/...), while the Node plugin resolves its own location to /private/var/... via import.meta.url, so the skill-path assertions compared mismatched strings and 5 OpenCodePluginTest cases failed on macOS. Linux CI stayed green because /var is not a symlink there, hiding the bug.
Resolve the temp root with os.path.realpath in setUp so both sides use the same canonical path. No behavior change to the skill or plugin; on Linux realpath is a no-op, so CI is unaffected.
Verification: python3 -m unittest discover -s tests — before: 5 failures (OpenCodePluginTest skill-path assertions); after: Ran 51 tests ... OK.
Summary
Authorship and provenance — select exactly one
Agent/tool and model/version:
Agent contribution:
Human verification:
Known limitations or uncertain results:
Labels
Target label:
Author label:
Workflow labels:
Safety and side effects
Side effects, permissions, network access, and cost:
Compatibility
Migration or rollback notes:
Verification
<command>—<result>Behavior evals:
Final accountability