Skip to content

fix(hooks): trim PowerShell trailing blank lines;Fix/powershell trailing newlines - #203

Draft
aprashnasuraj-dev wants to merge 2 commits into
ayghri:mainfrom
aprashnasuraj-dev:fix/powershell-trailing-newlines
Draft

fix(hooks): trim PowerShell trailing blank lines;Fix/powershell trailing newlines#203
aprashnasuraj-dev wants to merge 2 commits into
ayghri:mainfrom
aprashnasuraj-dev:fix/powershell-trailing-newlines

Conversation

@aprashnasuraj-dev

@aprashnasuraj-dev aprashnasuraj-dev commented Sep 13, 2026

Copy link
Copy Markdown

Summary

Authorship and provenance — select exactly one

  • Human-authored — substantive implementation and text were produced by a human.
  • Autonomous agent-authored — an agent planned and produced most of the substantive change.
  • Hybrid — a human and one or more agents both made substantive contributions.

Agent/tool and model/version:

Agent contribution:

Human verification:

Known limitations or uncertain results:

Labels

Target label:

Author label:

Workflow labels:

Safety and side effects

  • The change does not access or expose secrets, private files, or unrelated user/repository data.
  • Scripts, hooks, workflows, and evals are bounded and do not create surprising or irreversible side effects.
  • No destructive, privileged, production, externally visible, or persistent action occurs without explicit user intent and appropriate safeguards.
  • Network access, third-party code, permissions, and provider costs are minimized and documented.
  • Prompt text, examples, and fixtures contain no hidden instructions that weaken safety or expand agent authority.

Side effects, permissions, network access, and cost:

Compatibility

  • This is not a breaking change.
  • This is a breaking change; it was discussed, and migration/deprecation documentation is included below.
  • Canonical and mirrored skill files are synchronized when applicable.
  • Relevant platform manifests and installation documentation were reviewed.

Migration or rollback notes:

Verification

  • <command><result>

Behavior evals:

Final accountability

  • I reviewed the complete diff, removed unrelated generated changes, and take responsibility for the submitted content.
  • All failed, skipped, or unrun checks are disclosed above.

@aprashnasuraj-dev

Copy link
Copy Markdown
Author

This looks like more than simply “GitHub being down.” There are now reproducible cases showing transient runner→STS network stalls being amplified by the action’s timeout behavior. In #1915, an STS request can remain pending indefinitely because the retry wrapper only runs after a promise rejects; a stalled request never reaches that retry path. #1848 also shows v6 ETIMEDOUT retries lasting long enough for the OIDC JWT itself to expire.

So I’d describe this as intermittent network/routing trouble combined with an action-side resilience gap, rather than a global STS outage. Until the per-request behavior is fixed, I would bound both the workflow/job timeout and action-timeout-s, keep retries finite, and preserve the failed runner/IP/STS endpoint information when it happens.

In other words: the initial stall may be infrastructure/network-related, but an hours-long hang does not have to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant