release: UX polish fixes to production - #208
Merged
Merged
Conversation
When anonymous users triggered the sign-in modal via gated features like session_limit, algorithm_lock, or category_controls, the modal stayed open after successful Google authentication because those trigger paths did not set pendingFeatureRef.current. The auto-close effect now unconditionally dismisses the modal when isAuthenticated becomes true, while still auto-opening the pending feature (sound, fullscreen, export, code, insight) when one was set.
…r link Migrate waitlist banner dismissal and enrollment flags from sessionStorage to localStorage so they persist across browser sessions. Users who dismissed the banner or joined the waitlist will no longer see it reappear after closing the tab. Also adds a 'Pro Plan' link in the footer bottom bar alongside Privacy Policy and Terms of Use, giving users a persistent way to navigate to the /pro page. - waitlistService: persistWaitlistEmail/readStoredWaitlistEmail now use localStorage with sessionStorage migration fallback - ProWaitlistBanner: dismissal flag reads/writes to localStorage with sessionStorage migration fallback - Footer: new 'Pro Plan' link in bottom bar (en/fr/ar) - Tests: updated assertions to localStorage, added migration fallback tests for both banner and service
When an authenticated user visits the landing page, the auth hydration window briefly shows a pulsing skeleton circle in the header before hideAvatar hides it. Adding !hideAvatar to the skeleton condition prevents this flash on pages that don't display the avatar.
…fter-auth fix: three UX polish fixes — modal auto-close, waitlist persistence, skeleton flash
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ayoub3bidi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution workflow
main: This PR targetsmainfor production release.Description
Merge UX polish fixes from
developintomainfor production release. Four targeted fixes that improve user experience across authentication, navigation, and landing page.Type of Change
Related Issues
Fixes # (addressed via PR #207 review feedback)
Changes Made
isAuthenticatedbecomes true, not just when a gated feature was pendingsessionStoragetolocalStoragewith migration fallback; added/profooter link with i18n support (en/fr/ar)hideAvatarcondition to prevent brief skeleton shimmer when auth state resolves on first loadmotion.buttonwith semantic<Link>for the Pro Plan footer link; addedsessionStoragefallback inwaitlistServiceandProWaitlistBannerwhenlocalStorageis unavailable (private browsing, quota exceeded)Testing
pnpm test:run)Test Results
Code Quality
pnpm lint)Performance Impact
Breaking Changes
Checklist
Additional Notes
This is a fast-track production release of UX polish fixes that have already been validated on
develop. All 4 commits have passed CI and been deployed to dev.bayanflow.com via Cloudflare Workers.